Closed Bug 1682960 Opened 1 month ago Closed 1 month ago

Ping name is not yet optional in JS and C++ Testing APIs

Categories

(Toolkit :: Telemetry, task, P1)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: chutten, Assigned: chutten)

References

Details

Attachments

(1 file)

The ping name (currently erroneously called aStorageName) is actually optional in test_get_value way down in the Glean SDK Rust Language Binding (RLB). Let's pass that semantic sugar up to JS and C++ consumers.

Optional AUTF8String params on xpidl methods are permitted, coming through as being Empty (possibly also Void) nsACString&s. We're currently checking for emptiness as a signal to map an optional nsACString to None in Ping's submit method (for the reason), so this will mean that "" will be the same as absent.

Since we don't support pings or reasons or anything being defined in {metrics|pings}.yaml as empty strings (right?) this'll be a fine overlap.

Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2a095ef323d
Make the ping name optional in FOG JS and C++ test APIs r=janerik
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.