1682971 - tree-line white when treechildren selected but not focused with light theme

Status: VERIFIED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

After bug 1679436 on light TB theme the tree-line stays white when the treechildren is selected but not focused.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1682971-twisty-tree-line-colors.patch

On 78 there is only the tree-line (the dotted lines that connect the messages in threads) issue. On Daily there is also the twisty.

For 78 I'll create a patch with only the tree-line fix.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9193612 [details] [diff] [review]
1682971-twisty-tree-line-colors.patch

Review of attachment 9193612 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8ed1bfd4a3b0
Fix the tree-twisty and tree-line color when the treechildren isn't focused. r=aleca

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1682971-tree-line-colors-ESR.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 1679436
User impact if declined: wrongly colored tree-lines
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): very low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9193718 [details] [diff] [review]
1682971-tree-line-colors-ESR.patch

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 85.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/c3f63526f023

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9193718 [details] [diff] [review]
1682971-tree-line-colors-ESR.patch

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.6.1:
https://hg.mozilla.org/releases/comm-esr78/rev/bb881760efaf

Comment 9

[WaltS48 [:walts48]]

Looks good in 78.6.1 rc on Windows 10.