[wpt-sync] Sync PR 26935 - Handle inner fieldset / legend multicol at outer boundary.
Categories
(Core :: Layout: Columns, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox86 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 26935 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/26935
Details from upstream follow.
b'Morten Stenshorne <mstensho@chromium.org>' wrote:
Handle inner fieldset / legend multicol at outer boundary.
This used to fail a DCHECK when nested multicol was specified on a
fieldset at an outer fragmentainer boundary, but apart from that, it
worked fine, because BreakBeforeChildIfNeeded() correctly detects the
situation (abortion) and inserts a break before. Just move the DCHECK a
bit down.No code changes are required for legends, as they are monolithic. Just
replace the TODO with a proper comment, and keep the DCHECK (the legend
test also passes without the code changes in this CL).Bug: 829028
Change-Id: I62bf97f9bd04c185f86e93103f204cc6d872c438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595288
Reviewed-by: Alison Maher \<almaher@microsoft.com>
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837755}
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc58aef69eb0896348220a92ff402cae8dd94767
Assignee | ||
Comment 2•3 years ago
|
||
CI Results
Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests
Status Summary
Firefox
PASS: 1
FAIL: 1
Chrome
PASS: 1
FAIL: 1
Safari
PASS: 2
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
Firefox-only Failures
/css/css-multicol/nested-at-outer-boundary-as-legend.html: FAIL
New Tests That Don't Pass
/css/css-multicol/nested-at-outer-boundary-as-legend.html: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/85ebf695ef56 [wpt PR 26935] - Handle inner fieldset / legend multicol at outer boundary., a=testonly https://hg.mozilla.org/integration/autoland/rev/0c3fd77fc02b [wpt PR 26935] - Update wpt metadata, a=testonly
Comment 4•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/85ebf695ef56
https://hg.mozilla.org/mozilla-central/rev/0c3fd77fc02b
Description
•