Closed Bug 1683013 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 26938 - Prevent contenteditable anchors from being stuck :active

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26938 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26938
Details from upstream follow.

b'Joey Arhar <jarhar@chromium.org>' wrote:

Prevent contenteditable anchors from being stuck :active

Without this patch, anchors can be stuck in the :active state if
contenteditable is enabled before :active is removed.

The special logic for anchors and contenteditable was added a long time
ago [1], and the purpose was to prevent anchors from being clicked and
navigating the page while in contenteditable.

This patch makes SetActive capable of removing :active during
contenteditable, which preserves the original intention of preventing
anchors from navigating during contenteditable.

[1] http://crrev.com/1d651243ad5b85bac9ebc8611a991a23d72d2f95

Fixed: 1007941
Change-Id: Ib51b846e99fd212a478f1278b3568bda4e5886a0
Reviewed-on: https://chromium-review.googlesource.com/2595978
WPT-Export-Revision: 158466c6860da2cd8b51ca4e76795c6eb96dba5a

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS: 2

Chrome

OK : 2
PASS: 1
FAIL: 1

Safari

OK : 2
PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6e4cbb5ea0d9 [wpt PR 26938] - Prevent contenteditable anchors from being stuck :active, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.