1683110 - Jit tests on OSX are still using python 2

Status: RESOLVED FIXED

(Testing :: General, enhancement, P3)

Description

[Nicolas B. Pierron [:nbp]]

Bug 1668361 introduces uses of tempdile.Temporarydirectory (added in python 3.2) in order to cache state which would otherwise be re-computed hundred of thousands of times in the test suite. (taking at least ~10% of JIT test execution: try push)

Unfortunately, OSX 10.14 seems to be the only platform which does not yet use python 3 to setup the virtual env: https://treeherder.mozilla.org/logviewer?job_id=324823912&repo=try&lineNumber=67

And causes error when the test is executed: https://treeherder.mozilla.org/logviewer?job_id=324823912&repo=try&lineNumber=1376

Comment 1

[James Graham [:jgraham]]

I'm not sure this is a wpt issue? Isn't it about the configuration of the jittest job? Which right at this moment we seem to only be running on osx, at least as a seperate job.

Anyway, I changed the task configuration and made a try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=88aec785d1c3b0ff043def6da64a06e709223c42

Joel: you might want to triage this?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

odd, I don't see reference to running jittest on linux or windows, I believe that is because we run jsreftest or spidermonkey instead? In the try push the android on device JITTEST are failing with many failures.

as for using python3, I don't know the roadmap here. This is something I am not too familiar with and nobody on my team is working on this (:bc has landed a lot of py lint work, but that was sort of a getting things prepared vs migrating). Looking simply at this we run python3 run-task python2 <mozharness>, so I imagine we need to fix mozharness, then the test harness to be py3.

I have included :mtabara on the bug so he is aware there are more reasons to upgrade to python3 than a supported version. Ideally we can figure out a time or get approval for some resources to migrate to python3 which would solve this bug.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

there is a way to reduce the amount of work by having taskcluster specify per suite to use py3:
https://searchfox.org/mozilla-central/source/taskcluster/ci/test/web-platform.yml#49

I did a try push and it seems to work, :nbp, could you take a look at tell me if this is the desired outcome?

https://treeherder.mozilla.org/jobs?repo=try&revision=efec3b32512141f94cb3ee1ad4dff0322b1297b7

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

while this works great on osx and android, it seems to fail on win32 and win64:
https://treeherder.mozilla.org/jobs?repo=try&revision=cfe6d0dfa1924eb0b720ce966bc0140a4628b988

possibly we could skip this for win*, or possibly fixing pywin32 for py3 would be relatively easy as a quick google search shows pywin32 for various modern python versions:
https://sourceforge.net/projects/pywin32/files/pywin32/Build%20220/

Comment 5

[Nicolas B. Pierron [:nbp]]

(In reply to Joel Maher ( :jmaher ) (UTC -0800) from comment #3)

I did a try push and it seems to work, :nbp, could you take a look at tell me if this is the desired outcome?

https://treeherder.mozilla.org/jobs?repo=try&revision=efec3b32512141f94cb3ee1ad4dff0322b1297b7

This looks good to me!
Thanks.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1683110 - run compiled tests as python 3

run compiled tests w/python3

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63ea0e274356
run compiled tests as python 3 r=aki

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/63ea0e274356

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out on suspicion of causing Android Jittests to fail with exception and getting phones stuck (bug 1689389):

https://hg.mozilla.org/integration/autoland/rev/2061a47a198013363d832f6e1ca02b1f559fab1c

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5efe821951f9
run compiled tests as python 3 r=aki

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5efe821951f9