1683220 - Remove nsJSContext::MaybeRunNextCollectorSlice machinery

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect, P3)

Description

[Steve Fink [:sfink] [:s:]]

This appears to have been for a benchmark-only optimization. In my testing, it no longer seems to register a difference on our benchmarks: https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=22afd790922a76cab66b5e5f453acc7c0b8b383b&newProject=try&newRevision=82796b3bf19a4c4ffc1a4ff872e0dd6ed741b6cb

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1683220 - Remove nsJSContext::MaybeRunNextCollectorSlice entirely

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f99f3809630
Remove nsJSContext::MaybeRunNextCollectorSlice entirely r=smaug

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/8f99f3809630

Comment 4

[Steve Fink [:sfink] [:s:]]

[https://treeherder.mozilla.org/perfherder/alerts?id=28264] browsertime results are not good at all. I had only checked raptor and talos. I will need to rethink this.

Comment 5

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #28218 (as of Thu, 24 Dec 2020 00:47:25 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
7%	dromaeo_css		windows10-64-shippable-qr	e10s stylo webrender	14,275.44 -> 15,334.10
6%	dromaeo_css		windows10-64-shippable	e10s stylo	14,314.66 -> 15,223.53
6%	dromaeo_css		linux64-shippable-qr	e10s stylo webrender	15,835.58 -> 16,746.79
6%	dromaeo_css		linux64-shippable	e10s stylo	15,892.72 -> 16,802.35

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28218

Comment 6

[Razvan Maries]

Backed out for performance regression (bug 1684434).

Backout link: https://hg.mozilla.org/integration/autoland/rev/3b89ec779921198d17b1d195b9cd5c90973e007d

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/3b89ec779921

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:sfink, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[Steve Fink [:sfink] [:s:]]

I think it's useful after all, and the code is also called from DOMWindowUtils or whatever it's called. So removing these sources wouldn't clean it all up anyway.