1683228 - ConsoleInstance.cpp incorrectly fallback to All when maxLogLevelPref doesn't exist

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Ping Chen [:rnons] (away)]

From the doc https://searchfox.org/mozilla-central/rev/8d722de75886d6bffc116772a1db8854e34ee6a7/dom/webidl/Console.webidl#229-232, if the pref doesn't exist, should fallback to the maxLogLevel, but the implementation https://searchfox.org/mozilla-central/rev/8d722de75886d6bffc116772a1db8854e34ee6a7/dom/console/ConsoleInstance.cpp#45 always fallback to All

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1683228 - Fallback to maxLogLevel when maxLogLevelPref doesn't exist. r=smaug

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: Bug 1683228 - Check maxLogLevelPref value each time and use it when available. r=smaug

Depends on D100074.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5077eb1ad67c
Fallback to maxLogLevel when maxLogLevelPref doesn't exist. r=smaug

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5077eb1ad67c

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bc433def946
Check maxLogLevelPref value each time and use it when available. r=smaug

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3bc433def946

Comment 7

[Magnus Melin [:mkmelin]]

No need to close the bug yourself. It will (should) get closed when the actual merge to mozilla-central happens (and the final changeset is added to the bug, like comment 6.)