Intermittent GeckoProfiler.Markers | Failed
Categories
(Core :: Gecko Profiler, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: mozbugz)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Filed by: ccoroiu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=324923638&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Rkrif2EPQYm5p96bnmChcg/runs/0/artifacts/public/logs/live_backing.log
[task 2020-12-18T12:10:17.754Z] 12:10:17 INFO - TEST-START | GeckoProfiler.Markers
[task 2020-12-18T12:10:18.373Z] 12:10:18 WARNING - TEST-UNEXPECTED-FAIL | GeckoProfiler.Markers | Failed
[task 2020-12-18T12:10:18.373Z] 12:10:18 INFO - Unknown marker schema 'GCMinor' @ /builds/worker/checkouts/gecko/tools/profiler/tests/gtest/GeckoProfiler.cpp:1660
[task 2020-12-18T12:10:18.373Z] 12:10:18 INFO - Profiler buffer range: 87436 .. 440148 (3174408 bytes)
[task 2020-12-18T12:10:18.373Z] 12:10:18 INFO - Stats: min(us) .. mean(us) .. max(us) [count]
[task 2020-12-18T12:10:18.373Z] 12:10:18 INFO - - Intervals: 75.0 .. 4227.8 .. 12215.6 [145]
[task 2020-12-18T12:10:18.373Z] 12:10:18 INFO - - Overheads: 29.9 .. 170.2 .. 12203.4 [146]
[task 2020-12-18T12:10:18.373Z] 12:10:18 INFO - - Locking: 0.3 .. 89.3 .. 12104.4 [146]
[task 2020-12-18T12:10:18.373Z] 12:10:18 INFO - - Clearning: 1.0 .. 4.5 .. 14.6 [146]
[task 2020-12-18T12:10:18.373Z] 12:10:18 INFO - - Counters: 4.5 .. 16.7 .. 77.5 [146]
[task 2020-12-18T12:10:18.374Z] 12:10:18 INFO - - Threads: 23.4 .. 59.7 .. 141.5 [146]
[task 2020-12-18T12:10:18.404Z] 12:10:18 WARNING - TEST-UNEXPECTED-FAIL | GeckoProfiler.Markers | test completed (time: 636ms)
[task 2020-12-18T12:10:18.404Z] 12:10:18 INFO - TEST-START | GeckoProfiler.Counters
[task 2020-12-18T12:10:19.485Z] 12:10:19 INFO - TEST-PASS | GeckoProfiler.Counters | test completed (time: 1108ms)
[task 2020-12-18T12:10:19.485Z] 12:10:19 INFO - TEST-START | GeckoProfiler.Time
[task 2020-12-18T12:10:19.485Z] 12:10:19 INFO - TEST-PASS | GeckoProfiler.Time | test completed (time: 0ms)
[task 2020-12-18T12:10:19.494Z] 12:10:19 INFO - TEST-START | GeckoProfiler.GetProfile
[task 2020-12-18T12:10:19.518Z] 12:10:19 INFO - TEST-PASS | GeckoProfiler.GetProfile | test completed (time: 18ms)```
|
Assignee | |
Comment 1•5 years ago
|
||
I'll remove this failure case, it's not useful.
|
|
Assignee | |
Comment 2•5 years ago
|
||
This gtest failure was useful during early development of markers 2.0 schema, to catch all known (at the time) marker types, so they could be tested.
But now that most marker types live locally where they're used, they cannot easily be unit-tested here, so it's easy to miss some of those types. And more of them will be added in the future, potentially causing more failures here.
At the same time, these Profiler tests run along with lots of other tests, which may "naturally" produce some of those marker types, in which case the corresponding schema will be present in output profiles when running Profiler tests.
So we shouldn't make our tests fail anymore when encountering unknown marker types. They may still be verified in other tests related to the code they live in (e.g., an XPCShell test could exercise some Firefox functionality that generates markers when profiling.)
There is still a benign printf message, which may be useful during development, but shouldn't appear as a failure (to be fixed) in CI.
| Comment hidden (Intermittent Failures Robot) |
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
| Comment hidden (Intermittent Failures Robot) |
Description
•