Closed Bug 1683340 Opened 6 months ago Closed 6 months ago

Enable ESLint rule no-async-promise-executor on the remainder of the tree (mainly dom/)

Categories

(Core :: DOM: Core & HTML, task, P2)

task
Points:
2

Tracking

()

RESOLVED FIXED
86 Branch
Iteration:
86.2 - Dec 28 - Jan 10
Tracking Status
firefox86 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

When we upgraded to ESLint 6, we disabled the no-async-promise-executor rule for various files as it wasn't a quick enable.

This bug is for dom/ and the final file in netwerk/

Some notes about this rule (from ESlint's site):

The Promise executor function can be an async function. However, this is usually a mistake, for a few reasons:

  • If an async executor function throws an error, the error will be lost and won’t cause the newly-constructed Promise to reject. This could make it difficult to debug and handle some errors.
  • If a Promise executor function is using await, this is usually a sign that it is not actually necessary to use the new Promise constructor, or the scope of the new Promise constructor can be reduced.
Severity: -- → N/A
Priority: -- → P2
Iteration: 86.1 - Dec 14 - Dec 27 → 86.2 - Dec 28 - Jan 10
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e3c5aa82055
Enable ESLint rule no-async-promise-executor for test_http2-proxy.js. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/1a4ab71a3bef
Enable ESLint rule no-async-promise-executor for dom/payments. r=baku
https://hg.mozilla.org/integration/autoland/rev/349c2b540598
Enable ESLint rule no-async-promise-executor for the remaining dom/ files. r=nika
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.