1683340 - Enable ESLint rule no-async-promise-executor on the remainder of the tree (mainly dom/)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Description

[Mark Banner (:standard8)]

When we upgraded to ESLint 6, we disabled the no-async-promise-executor rule for various files as it wasn't a quick enable.

This bug is for dom/ and the final file in netwerk/

Some notes about this rule (from ESlint's site):

The Promise executor function can be an async function. However, this is usually a mistake, for a few reasons:

• If an async executor function throws an error, the error will be lost and won’t cause the newly-constructed Promise to reject. This could make it difficult to debug and handle some errors.
• If a Promise executor function is using await, this is usually a sign that it is not actually necessary to use the new Promise constructor, or the scope of the new Promise constructor can be reduced.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1683340 - Enable ESLint rule no-async-promise-executor for test_http2-proxy.js.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1683340 - Enable ESLint rule no-async-promise-executor for dom/payments. r?edenchuang!

Depends on D100134

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1683340 - Enable ESLint rule no-async-promise-executor for the remaining dom/ files. r?nika!

Depends on D100135

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e3c5aa82055
Enable ESLint rule no-async-promise-executor for test_http2-proxy.js. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/1a4ab71a3bef
Enable ESLint rule no-async-promise-executor for dom/payments. r=baku
https://hg.mozilla.org/integration/autoland/rev/349c2b540598
Enable ESLint rule no-async-promise-executor for the remaining dom/ files. r=nika

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6e3c5aa82055
https://hg.mozilla.org/mozilla-central/rev/1a4ab71a3bef
https://hg.mozilla.org/mozilla-central/rev/349c2b540598