168352 - Lots of getElementById assertions

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Simon Fraser [no longer active]]

Lots of these assertions, typing in the url bar, and quitting. Stack:

 Calling chain using A6/R1 links
  Back chain  ISA  Caller
  00000000    PPC  3E908B30  
  133F77F0    PPC  3E8E5EDC  main+001AC
  133F7790    PPC  3E8E3C90  main1(int, char**, nsISupports*)+00B20
  133F75C0    PPC  3E4751F4  nsAppShellService::Run()+00054
  133F7570    PPC  3AAEA3E0  nsAppShell::Run()+00040
  133F7530    PPC  3AAEAE04  nsMacMessagePump::DoMessagePump()+00044
  133F74E0    PPC  3AAEB028  nsMacMessagePump::DispatchEvent(int,
EventRecord*)+00078
  133F7470    PPC  3AAEC8A8  nsMacMessagePump::DoKey(EventRecord&)+00038
  133F7420    PPC  3AAED03C 
nsMacMessagePump::DispatchOSEventToRaptor(EventRecord&, GrafPort
*)+0013C
  133F73A0    PPC  3AAE0134  nsMacWindow::DispatchEvent(void*, int*)+00044
  133F7360    PPC  3AAE2DA0  nsMacEventHandler::HandleOSEvent(EventRecord&)+00050
  133F7310    PPC  3AAE42DC  nsMacEventHandler::HandleKeyEvent(EventRecord&)+0020C
  133F7220    PPC  3AAC95A8  nsWindow::DispatchWindowEvent(nsGUIEvent&)+00028
  133F71E0    PPC  3AAC94A4  nsWindow::DispatchEvent(nsGUIEvent*,
nsEventStatus&)+000C4
  133F7190    PPC  3ABC4D34  HandleEvent(nsGUIEvent*)+00054
  133F7140    PPC  3ABD39F4  nsViewManager::DispatchEvent(nsGUIEvent*,
nsEventStatus*)+00C74
  133F6F00    PPC  3ABC5B0C  nsView::HandleEvent(nsViewManager*, nsGUIEvent*,
int)+0002C
  133F6EC0    PPC  3ABD4904  nsViewManager::HandleEvent(nsView*, nsGUIEvent*,
int)+00214
  133F6D60    PPC  3C2C60BC  PresShell::HandleEvent(nsIView*, nsGUIEvent*,
nsEventStatus*, in
t, int&)+008BC
  133F6C20    PPC  3C2C65D4  PresShell::HandleEventInternal(nsEvent*, nsIView*,
unsigned int,
 nsEventStatus*)+00154
  133F6BB0    PPC  3D90CA2C  nsHTMLInputElement::HandleDOMEvent(nsIPresContext*,
nsEvent*, ns
IDOMEvent**, unsigned int, nsEventStatus*)+00E2C
  133F6630    PPC  3D9CA5B0  nsGenericElement::HandleDOMEvent(nsIPresContext*,
nsEvent*, nsID
OMEvent**, unsigned int, nsEventStatus*)+01160
  133F6310    PPC  3D844B40 
nsEventListenerManager::HandleEvent(nsIPresContext*, nsEvent*, n
sIDOMEvent**, nsIDOMEventTarget*, unsigned int, nsEventStatus*)+020F0
  133F5DF0    PPC  3D0F4D40  nsTextEditorKeyListener::KeyPress(nsIDOMEvent*)+00CF0
  133F5CD0    PPC  3D1FE8CC 
nsPlaintextEditor::HandleKeyPress(nsIDOMKeyEvent*)+0021C
  133F5BB0    PPC  3D1FEA4C  nsPlaintextEditor::TypedText(const nsAString&,
int)+000EC
  133F5B30    PPC  3D203554  nsPlaintextEditor::InsertText(const nsAString&)+00484
  133F5990    PPC  3D14184C  nsTextEditRules::WillDoAction(nsISelection*,
nsRulesInfo*, int*,
 int*)+000FC
  133F5940    PPC  3D143054  nsTextEditRules::WillInsertText(int, nsISelection*,
int*, int*, 
const nsAString*, nsAString*, int)+00294
  133F5560    PPC  3D141E74  nsTextEditRules::WillInsert(nsISelection*, int*)+000A4
  133F5500    PPC  3D0D5410  nsEditor::DeleteNode(nsIDOMNode*)+00240
  133F5470    PPC  3D0CF278  nsEditor::Do(nsITransaction*)+00538
  133F5370    PPC  3F0A6E94 
nsTransactionManager::DoTransaction(nsITransaction*)+000D4
  133F5320    PPC  3F0AA0D8 
nsTransactionManager::BeginTransaction(nsITransaction*)+00118
  133F52D0    PPC  3F0AADEC  nsTransactionItem::DoTransaction()+0002C
  133F5290    PPC  3D0C5B00  DeleteElementTxn::DoTransaction()+005C0
  133F5030    PPC  3D8CC5C0  nsHTMLDivElement::RemoveChild(nsIDOMNode*,
nsIDOMNode**)+00030
  133F4FE0    PPC  3D9CEAEC  nsGenericElement::doRemoveChild(nsIDOMNode*,
nsIDOMNode**)+0011C
  133F4F70    PPC  3D898E50  nsGenericHTMLContainerElement::RemoveChildAt(int,
int)+002F0
  133F4EA0    PPC  3DB7F184  nsXULDocument::ContentRemoved(nsIContent*,
nsIContent*, int)+000
34
  133F4E30    PPC  3DB8B494 
nsXULDocument::RemoveSubtreeFromDocument(nsIContent*)+006F4
  133F4B90    PPC  3DB89B18  nsXULDocument::GetElementById(const nsAString&,
nsIDOMElement**)
+00088
  133F4B10    PPC  3E077A7C  nsDebug::WarnIfFalse(const char*, const char*,
const char*, int)
+0002C
  133F4AD0    PPC  3E07784C  nsDebug::Assertion(const char*, const char*, const
char*, int)+0
005C
 Closing log

Comment 1

[Brendan Eich [:brendan]]

Why would this be hyatt's bug?  Don't do what I scold timeless for doing, file
misassigned bugs with no one on the cc: list.

The warning is about id="" or equivalent (empty string for DOM id attribute
value).  Sounds like a bug somewhere above nsXULDocument, possibly in a .xul
file or nearby.  Please debug a bit more.

/be

Comment 2

[(not reading, please use [e-mail] instead)]

a dup:  http://bugzilla.mozilla.org/show_bug.cgi?id=168306

Comment 3

[David Hyatt]

Attachment: Fix assertions...

Comment 4

[Brendan Eich [:brendan]]

Argh.

Simon, I'm sorry -- I didn't know hyatt told you to file this on him.  I've got
to stop watching hyatt's bugs (he gets a lot of bogus ones).  Turns out sspitzer
blamed danm in a dup (bug 168306).  I'm going to go soak my head now.

/be

Comment 5

[(not reading, please use [e-mail] instead)]

*** Bug 168306 has been marked as a duplicate of this bug. ***

Comment 6

[(not reading, please use [e-mail] instead)]

I get tons of these when I close windows:

###!!! ASSERTION: getElementById(""), fix caller?: '!aId.IsEmpty()', file c:/bui
lds/buffy/mozilla/content/xul/document/src/nsXULDocument.cpp, line 3746

yes, I was the one to condem.  I just lobbed it over the wall at danm.

(apologies to danm)

Comment 7

[David Hyatt]

r/sr needed.  All I did was do hasAttr checks first... and then I also check 
the value even if it has the attr to make sure that's non-empty.  That should 
bulletproof against ever calling getElementById with an empty string.

Comment 8

[Brendan Eich [:brendan]]

Comment on attachment 98960 [details] [diff] [review]
Fix assertions...

Hyatt says he fixed the evil tabs by fixing MSVC's settings.

sr=[e-mail], hope that helps make up for my blundering.

/be

Comment 9

[Brian Ryner (not reading)]

Comment on attachment 98960 [details] [diff] [review]
Fix assertions...

r=bryner

Comment 10

[David Hyatt]

Fixed.