168358 - error when validating user input with javascript

Status: VERIFIED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Arif Kurniawan]

sorry for my poor english

when i use javascript to validate form input like this

<script language="javascript">
function cek_input(){
	if (document.form1.kategori.selectedIndex==0){
 		alert("Anda belum memilih kategori");
  		document.form1.kategori.focus();
  		return false;
  }
	if(document.form1.judul.value==""){
		alert('Judul tidak boleh kosong');
		form1.judul.focus();
		return false;}
	if(document.form1.isi.value==""){
		alert('Isi tidak boleh kosong');
		form1.isi.focus();
		return false;}
	if(document.form1.sel_tahun.value==""){
		alert('Tahun tidak boleh kosong');
		form1.sel_tahun.focus();
		return false;}
	
	return true;
}
then I add form:
<form name=form1 action=... onsubmit="return cek_input();">
....
...
this is doesn't work (sometimes it's works, so strange)

Comment 1

[Andrew Schultz]

- form1.XXXX.focus();
+ document.form1.XXXX.focus();

that gets it working for me.

Comment 2

[Vladimir Ermakov]

Looks like invalid code, but moving to JS Engine for a final decision. Perhaps a
shortcut like this could be useful?

Comment 3

[Phil Schwartau]

Browser, not engine ---> DOM Level 0

Arif: could you attach a small reduced testcase to this bug
via the "Create a New Attachment" link above? Thanks; that will
speed things along -

Please attach it as type "text/plain", since the Bugzilla
server doesn't like the form submit when we click on it.

Also, you mention you get an error. Do you see that in Mozilla
Tools > Web Development > JavaScript Console? (be sure to clear
this of any previous errors first).

What does the error say?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Andrew is right.  A shortcut like this was considered, and jst is dead-set
against it, for a number of reasons.

Comment 5

[Vladimir Ermakov]

Verifying.