1683581 - The .jpg extension of images online got renamed .jpeg when you save them

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[Colar]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

Go to http://www.lpdc.be/firefox/image.jpg (or any jpg image with a .jpg extension), right clic and Save as.

Actual results:

The name of the file in the "Save popup" (I don't know how it's called in English) becomes image.jpeg and if you hit enter you obviously got image.jpeg on your hard drive

It happens since last update (from 83 to 84), it worked correctly before that.

Expected results:

File name should be the same as on the web server: image.jpg

I'll add that I'm not fluent in English, sorry for that, and I use Ubuntu 16.04.7.

Comment 1

[Tom S [:evilpie]]

The problems seems to be in getDefaultExtension in contentAreaUtils.js. This code forces a new file-extension for images, even if that extension is already correct for that MIME type.

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1683581 - Don't overwrite valid alternative image file-extensions. r?Gijs

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1667787

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70234746857e
Don't overwrite valid alternative image file-extensions. r=Gijs

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/70234746857e

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:evilpie, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Tom S [:evilpie]]

While this might be annoying behavior, I don't think it requires an uplift. Forwarding to Gijs though.

Comment 8

[:Gijs (he/him)]

(In reply to Tom Schuster [:evilpie] from comment #7)

While this might be annoying behavior, I don't think it requires an uplift. Forwarding to Gijs though.

I think given the other regressions filed against bug 1667787, we'll want to look at those in January, and so uplifting this would also make sense to avoid inconsistencies. There's no beta build until the middle of the first week of Jan, so I can fill out the form then, I guess. Will keep needinfo to remind me.

Comment 9

[:Gijs (he/him)]

Comment on attachment 9194198 [details]
Bug 1683581 - Don't overwrite valid alternative image file-extensions. r?Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Firefox overwrites extensions for downloaded images
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: See comment #0
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only affect image downloads. We're reordering existing code in a single helper function, slightly simplifying it, and there are additional tests.
• String changes made/needed: nope

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 9194198 [details]
Bug 1683581 - Don't overwrite valid alternative image file-extensions. r?Gijs

approved for 85.0b5

Comment 11

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cbae3512fe86