Closed Bug 1683586 Opened 4 months ago Closed 4 months ago

Remove "mailBoxes" and "addressBooks" support in nsIImportGeneric setData()/getData()

Categories

(MailNews Core :: General, task)

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
86 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: benc, Assigned: benc)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As part of Bug 1612240, I removed explicit nsIArray use from the interfaces in mailnews/import/, but there are still some implied uses, via nsImportGeneric.getData() and .setData(). The "mailBoxes" and "addressBooks" dataIds still deal in nsIArrays, passing them through the interface as nsISupports pointers.

Pretty straightforward, but I'm still not confident this isn't going to screw up some external bit of code somewhere that relies on it :-)

Attachment #9194159 - Flags: review?(mkmelin+mozilla)
Blocks: 1683588
Comment on attachment 9194159 [details] [diff] [review]
1683586-remove-nsIArray-1.patch

Review of attachment 9194159 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine to me. r=mkmelin
Attachment #9194159 - Flags: review?(mkmelin+mozilla) → review+
Status: NEW → ASSIGNED
Target Milestone: --- → 86 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d6dffa872468
Remove "mailBoxes" and "addressBooks" support in nsIImportGeneric setData()/getData(). r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.