Open Bug 1683599 Opened 4 years ago Updated 3 years ago

Show unlabeled menu items in the filter context menu on the Synced Tabs

Categories

(Firefox :: Sync, defect, P3)

Firefox 84
defect

Tracking

()

People

(Reporter: k08045kk, Unassigned)

Details

Attachments

(1 file)

Attached image firefox.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

  1. Enable [Open tabs] in the sync settings
  2. Synchronize two Firefox
  3. Show the Synced Tabs in the sidebar
  4. Right-click on the text area at the top of the sidebar

Actual results:

Shows unlabeled menu items at the bottom of the context menu.
Also, when you click a menu item, the following error message is displayed on the console of the browser development tool.

TypeError: can't access property "doCommand", controller is nullTabListView.js:528:5
handleTabsFilterContextMenuCommand resource:///modules/syncedtabs/TabListView.js:528
handleEvent resource:///modules/syncedtabs/TabListView.js:467

The id of the menu item is "#syncedTabsRefreshFilter".

Expected results:

Display a meaningful label on the menu item. Alternatively, hide the context menu that doesn't work.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Sync

Thanks for the report - not sure why it's showing up on the text field - it appears to work correctly in all other contexts (it's the "Sync Now" option). I think the solution here is to have it not show on the text field.

Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
QA Whiteboard: [fxsync-tabs]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: