1683654 - Bol.com, an included search engine for Dutch (NL) locale, does not work

Status: VERIFIED FIXED

(Firefox :: Search, defect, P2)

Description

[cbxpxztmp+p1aty]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

The Bol.com search engine in the Dutch locale of Firefox does not return relevant results

Please reconsider your collaboration with Bol.com, especially in case of a monetary incentive for Bol.com to be included with Firefox

Actual results:

No matter the search term, a Bol.com page with a generic inventory is returned

URL result from Bol.com search engine in Firefox: https://www.bol.com/nl/s/algemeen/zoekresultaten/Ntt/open/sc/media_all/Nty/1/suggestedFor/open/N/0/Ne/0/search/true/searchType/qck/index.html

Expected results:

Similar results to Bol.com's on-site search function should appear

URL result from Bol.com's own search function: https://www.bol.com/nl/s/?searchtext=open&searchContext=media_all&appliedSearchContextId=&suggestFragment=&adjustedSection=&originalSection=&originalSearchContext=&section=main&N=0&defaultSearchContext=media_all

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Mark Banner (:standard8)]

Thank you for the report, we're looking into this.

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1683654 - Fix the URL for bol.com searches

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cb4e86c1f61
Fix the URL for bol.com searches r=Standard8

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3cb4e86c1f61

Comment 6

[Dale Harvey (:daleharvey)]

Comment on attachment 9194309 [details]
Bug 1683654 - Fix the URL for bol.com searches

Beta/Release Uplift Approval Request

• User impact if declined: bol.com will remain broken for NL users
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Change language to NL, attempt to perform search at bol.com
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change to already broken search engine url
• String changes made/needed:

Comment 7

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

Reproduced the faulty search engine behavior on Fx 86.0a1 (2020-12-20), then procedeed to verify the qstring fix on Fx86.0a1 2020-12-24 using Ubuntu 20.04, Mac 10.14.6 and Windows 10. Plese note that the tests were performed with the fy-NL Nightly localization, since on Nightly there are additional pre-requisites to change the browser language.

A bit unrelated, but since it's the second time I'm hitting this and it might be an issue, Dale, do you know what other prefs are required on Nightly to be able to download and change the language? (intl.multilingual.enabled and intl.multilingual.downloadEnabled are not enough).

Comment 8

[Dale Harvey (:daleharvey)]

Sorry going to forward this to flod who will know better

I usually test this by hardcoding the changed locale in the source and recompiling, which I realise isnt helpful

Comment 9

[Francesco Lodolo [:flod]]

This should have all the answers
https://mozilla-l10n.github.io/documentation/products/firefox_desktop/firefox_l10n_faqs.html#how-can-i-test-a-different-locale

There are no options to download languages on Nightly, because language packs are not reliable.

Comment 10

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9194309 [details]
Bug 1683654 - Fix the URL for bol.com searches

approved for 85.0b5

Comment 11

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b8c769f17669

Comment 12

[Petruta Horea [:phorea], PTO until 8/22/25]

Verified as fixed using Firefox 85 beta 7, nl locale, under Win 10 64-bit and Ubuntu 18.04 64-bit.