Closed Bug 1683678 Opened 6 months ago Closed 6 months ago

Mask password button is no longer visible if Light theme is used

Categories

(Firefox :: about:logins, defect, P1)

Desktop
All
defect
Points:
1

Tracking

()

VERIFIED FIXED
86 Branch
Iteration:
86.2 - Dec 28 - Jan 10
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- unaffected
firefox85 --- verified
firefox86 --- verified

People

(Reporter: atrif, Assigned: dao)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image about_login_button.gif

Affected versions

  • 86.0a1(20201221093813)
  • 85.0b4 (20201220193140)

Affected platforms

  • Windows 10x64
  • macOS 10.15
  • Ubuntu 18.04

Preconditions

  • have a saved login and Light OS theme

Steps to reproduce

  1. Open about:logins and select a random login.
  2. Click on the Mask/ Unmask password button.

Expected result

  • Buttons are displayed as expected.

Actual result

  • Mask password button is invisible but can be activated.

Regression range

Notes

  • Attached a screen recording.

Suggested Severity: S3

Has Regression Range: --- → yes
Has STR: --- → yes
Assignee: nobody → dao+bmo
Severity: -- → S2
Status: NEW → ASSIGNED
Iteration: --- → 86.2 - Dec 28 - Jan 10
Points: --- → 1
Component: Themes → about:logins
Priority: -- → P1
Product: Toolkit → Firefox
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/296c58886005
Override common.css checkbox colors for the mask password button. r=ntim
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Flags: qe-verify+

Comment on attachment 9194864 [details]
Bug 1683678 - Override common.css checkbox colors for the mask password button. r=ntim

Beta/Release Uplift Approval Request

  • User impact if declined: see comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: see comment 0
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): trivial CSS fix
  • String changes made/needed:
Attachment #9194864 - Flags: approval-mozilla-beta?

Reproduced the initial issue using Firefox 85.0b4, verified that using todays Nightly 86.0a1 this is fixed across platforms (Windows 10, Ubuntu 18.04 and macOS 11).

Comment on attachment 9194864 [details]
Bug 1683678 - Override common.css checkbox colors for the mask password button. r=ntim

css fix, approved for 85.0b5

Attachment #9194864 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified fixed using Firefox 85.0b5 (20210105092155) from comment 7 on Windows 10x64, macOS 10.12 and Ubuntu 18.04. Mask password button is correctly displayed on Light OS theme.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.