1683819 - 14.08 - 17.38% cpstartup content-process-startup (linux64-shippable, linux64-shippable-qr) regression on push a6b10fddf201f7ac8b4afffeca5c3ef889ff5857 (Fri December 18 2020)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a talos performance regression from push a6b10fddf201f7ac8b4afffeca5c3ef889ff5857. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
17%	cpstartup	content-process-startup	linux64-shippable-qr	e10s stylo webrender-sw	106.92 -> 125.50
16%	cpstartup	content-process-startup	linux64-shippable	e10s stylo	102.75 -> 118.83
14%	cpstartup	content-process-startup	linux64-shippable-qr	e10s stylo webrender	111.25 -> 126.92

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Cameron McCormack (:heycam)]

This is because I preffed off the RemoteLookAndFeel in bug 1683204 due to a regression. Once the updated patch on that bug lands, the talos regressions should be addressed.

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

Alexandru, is that still an issue? Thanks

Comment 3

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Yes

Comment 4

[Jim Mathies [:jimm]]

REO comment - the regression still seems present.

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Stephen, do you think you could help with this bug? Thanks

Comment 6

[Brian Grinstead [:bgrins]]

It looks like this regression went away when enabling non native theming, but still marking 87 as affected since it's still TBD when it will ride the train. Bug 1411425 is tracking that.

Comment 7

[Stephen A Pohl [:spohl]]

(In reply to Pascal Chevrel:pascalc from comment #5)

Stephen, do you think you could help with this bug? Thanks

Since this is addressed with the non-native theme enabled, and since we're trying to roll non-native theming out on Linux, Windows and macOS at the same time, I'm going to focus on greening up the tree for macOS and Windows first. Should there be time left to fix this regression here before non-native theming is enabled, I will look into this. Leaving n-i set for now.

Comment 8

[Chris Peterson [:cpeterson]]

Linux bugs don't block Fission Beta experiment (on Windows and macOS), so I am moving Linux Fission bugs from Fission milestone M7 to M7a.

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Brian Grinstead [:bgrins] from comment #6)

It looks like this regression went away when enabling non native theming, but still marking 87 as affected since it's still TBD when it will ride the train. Bug 1411425 is tracking that.

Non-native theming is currently enabled by default in Nightly, but won't ride the trains until 89. So 88 will be the only release affected by this Linux cpstartup regression.

Stephen is out on PTO. If we need someone to debug this regression for 88, let me know and I can find another engineer.

Clearing the Fission Milestone since Fission will ship with non-native theming enabled.

Comment 10

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson [:cpeterson] from comment #9)

Clearing the Fission Milestone since Fission will ship with non-native theming enabled.

Adding [not-a-fission-bug] whiteboard tag to hide this bug from Fission's bug triage query.

Comment 11

[Stephen A Pohl [:spohl]]

Based on bug 1689359 comment 8, this was indeed addressed by enabling non-native theming on Linux in bug 1689359. Closing accordingly.