Closed Bug 1683847 Opened 3 years ago Closed 3 years ago

7.59 - 28.1% twitter / twitter loadtime (macosx1014-64-shippable-qr) regression on push 2d192d43277bb6231b9145572d0059c5964f9d96 (Tue December 15 2020)

Categories

(Core :: Networking: WebSockets, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1681030
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- unaffected
firefox85 --- unaffected
firefox86 --- affected

People

(Reporter: Bebe, Unassigned)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression)

Perfherder has detected a browsertime performance regression from push 2d192d43277bb6231b9145572d0059c5964f9d96. As author of one of the patches included in that push, we need your help to address this regression.

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
28% twitter loadtime macosx1014-64-shippable-qr cold nocondprof webrender 3,694.67 -> 2,656.62
8% twitter macosx1014-64-shippable-qr cold nocondprof webrender 746.36 -> 689.73

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(kershaw)
Flags: needinfo?(robert.mader)

I think bug 1675207 should have nothing to do with this.
After the push 2d192d43277bb6231b9145572d0059c5964f9d96, the patch in bug 1675207 was landed back in 3389a00741138b4c0d34ca9fb6bbb2860e743f0c. According to this graph, it seems that the push 2d192d43277bb6231b9145572d0059c5964f9d96 (without the patch in bug 1675207) and 3389a00741138b4c0d34ca9fb6bbb2860e743f0c (with the patch) have the same result.

In addition, bug 1675207 is all about websocket and thus is not related to wayland feature.

Florin, could you confirm what I said above is correct? Thanks.

Flags: needinfo?(kershaw) → needinfo?(fstrugariu)

Set release status flags based on info from the regressing bug 1675207

IIUC the patches should have nothing to do with each other.

FTR.: I found the underlying issue of bug 1681030, so we could revisit this once the fixes land (see also bug 1645528 comment 76)

Flags: needinfo?(robert.mader)
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(fstrugariu)
Resolution: --- → DUPLICATE
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.