Closed
Bug 1683966
Opened 3 years ago
Closed 3 years ago
Add autoreleasepools for more of WebRender
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
86 Branch
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
No description provided.
Assignee | ||
Updated•3 years ago
|
Blocks: autorelease-leaks
Assignee | ||
Comment 1•3 years ago
|
||
This isn't very systematic as I'm not sure the best approach for that
yet. That being said, this captures the bulk of the autoreleases without
that happen without a pool.
Updated•3 years ago
|
Assignee: nobody → jmuizelaar
Status: NEW → ASSIGNED
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02a79f770fcf Add some more objc autorelease pools. r=mstange
Comment 3•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Assignee | ||
Comment 4•3 years ago
|
||
Comment on attachment 9194478 [details]
Bug 1683966. Add some more objc autorelease pools.
Beta/Release Uplift Approval Request
- User impact if declined: Leaks of font data in various circumstances. Some kind of things as bug 1683418.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Adding an an extra autorelease pool should be very low risk.
- String changes made/needed:
Attachment #9194478 -
Flags: approval-mozilla-beta?
Comment 5•3 years ago
|
||
Comment on attachment 9194478 [details]
Bug 1683966. Add some more objc autorelease pools.
approved for 85.0b5
Attachment #9194478 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•3 years ago
|
||
bugherder uplift |
status-firefox85:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•