Closed Bug 1683985 Opened 3 years ago Closed 3 years ago

Remove obsolete `transform: translateY(-1.5px);` rule from .urlbarView-favicon

Categories

(Firefox :: Theme, task)

Product:
Firefox
Component:
Theme
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: ntim, Assigned: soniasingla, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file)

Bug 1683985 - Remove obsolete rule from .urlbarView-favicon. r=ntim
48 bytes, text/x-phabricator-request
Details | Review

Bug 1525890 added this rule, before bug 1534738 removed only the non-2dppx rule. I'm sure the 2dppx rule is obsolete too. It also makes the icons look slightly misaligned on Retina tbh.

https://searchfox.org/mozilla-central/rev/5a90b263f71b558fd14bade65b0c4ae5e216e646/browser/themes/shared/urlbarView.inc.css#210-215

Mentor: ntim.bugs
Keywords: good-first-bug
Whiteboard: [lang=css]
Assignee: nobody → soniasingla.1812
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6b0f61e93f9d
Remove obsolete  rule from .urlbarView-favicon. r=ntim,harry

https://hg.mozilla.org/mozilla-central/rev/6b0f61e93f9d

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: