1684231 - Build warning spam when NSPR is folded into NSS

Status: ASSIGNED

(Firefox Build System :: General, task)

Description

[Masatoshi Kimura [:emk]]

Attachment: buildlog.txt

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1684231 - Fix build warnings about importing local symbols. r?glandium

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a7372cdf019
Fix build warnings about importing local symbols. r=glandium

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages in security/moz.build.

Backout link: https://hg.mozilla.org/integration/autoland/rev/cc35e75fbace0c9155941a113104a340a5da1ea5

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Crunning%2Cpending%2Crunnable&searchStr=os%2Cx%2Ccross%2Ccompiled%2Copt%2Cbuild-macosx64%2Fopt%2Cb&revision=7a7372cdf019983c034cef3b411626fea878ef4b&selectedTaskRun=bDrlol8ISse3LdvbvEHPRQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=326066709&repo=autoland&lineNumber=1144

"INFO - Creating config.status
[task 2021-01-07T12:47:50.745Z] 12:47:50 INFO - Reticulating splines...
[task 2021-01-07T12:47:51.133Z] 12:47:51 ERROR - Traceback (most recent call last):
[task 2021-01-07T12:47:51.134Z] 12:47:51 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/sandbox.py", line 211, in exec_function
[task 2021-01-07T12:47:51.134Z] 12:47:51 INFO - func(*args, **kwargs)
[task 2021-01-07T12:47:51.134Z] 12:47:51 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/sandbox.py", line 188, in execute
[task 2021-01-07T12:47:51.134Z] 12:47:51 INFO - exec_(code, self)
[task 2021-01-07T12:47:51.134Z] 12:47:51 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/util.py", line 55, in exec_
[task 2021-01-07T12:47:51.134Z] 12:47:51 INFO - exec(object, globals, locals)
[task 2021-01-07T12:47:51.134Z] 12:47:51 INFO - File "/builds/worker/checkouts/gecko/security/moz.build", line 149, in <module>
[task 2021-01-07T12:47:51.135Z] 12:47:51 INFO - sandbox_vars["CFLAGS"] += ["-D_NSPR_BUILD_"]
[task 2021-01-07T12:47:51.135Z] 12:47:51 INFO - KeyError: 'CFLAGS'
[task 2021-01-07T12:47:51.135Z] 12:47:51 INFO - During handling of the above exception, another exception occurred:
[task 2021-01-07T12:47:51.135Z] 12:47:51 ERROR - Traceback (most recent call last):
[task 2021-01-07T12:47:51.135Z] 12:47:51 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1097, in read_mozbuild
[task 2021-01-07T12:47:51.135Z] 12:47:51 INFO - path, config, descend=descend, metadata=metadata
[task 2021-01-07T12:47:51.135Z] 12:47:51 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1168, in _read_mozbuild
[task 2021-01-07T12:47:51.135Z] 12:47:51 INFO - sandbox.exec_file(path)
[task 2021-01-07T12:47:51.135Z] 12:47:51 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 239, in exec_file
[task 2021-01-07T12:47:51.136Z] 12:47:51 INFO - Sandbox.exec_file(self, path)
[task 2021-01-07T12:47:51.136Z] 12:47:51 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/sandbox.py", line 165, in exec_file
[task 2021-01-07T12:47:51.136Z] 12:47:51 INFO - self.exec_source(source, path)
[task 2021-01-07T12:47:51.136Z] 12:47:51 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/sandbox.py", line 192, in exec_source
[task 2021-01-07T12:47:51.136Z] 12:47:51 INFO - self.exec_function(execute, path=path)
[task 2021-01-07T12:47:51.136Z] 12:47:51 INFO - File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/sandbox.py", line 244, in exec_function
[task 2021-01-07T12:47:51.136Z] 12:47:51 INFO - raise SandboxExecutionError(source_stack, exc[0], exc[1], exc[2])
[task 2021-01-07T12:47:51.137Z] 12:47:51 INFO - mozbuild.frontend.sandbox.SandboxExecutionError: (['/builds/worker/checkouts/gecko/security/moz.build'], <class 'KeyError'>, KeyError('CFLAGS'), <traceback object at 0x7ffaa8db6e08>)
[task 2021-01-07T12:47:51.137Z] 12:47:51 INFO - During handling of the above exception, another exception occurred:
[task 2021-01-07T12:47:51.137Z] 12:47:51 ERROR - Traceback (most recent call last):
[task 2021-01-07T12:47:51.137Z] 12:47:51 INFO - File "/builds/worker/checkouts/gecko/configure.py", line 231, in <module>"

Comment 4

[Razvan Maries]

Please also take a look at:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Erp8Q-ztT5yTk2SpyerPfA.0&fromchange=c6fec8df79cee18d5e9559c16afb916eb39bfc20&searchStr=windows%2C10%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s%2Cbc6&tochange=6801d25be0c2604726867933f29e0b1565e2cd41

https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6801d25be0c2604726867933f29e0b1565e2cd41&searchStr=reftest

Logs:
https://treeherder.mozilla.org/logviewer?job_id=326067345&repo=autoland&lineNumber=12864
https://treeherder.mozilla.org/logviewer?job_id=326067138&repo=autoland&lineNumber=1991
https://treeherder.mozilla.org/logviewer?job_id=326067346&repo=autoland&lineNumber=1917

Comment 5

[Masatoshi Kimura [:emk]]

Since nssckbi.dll is not folded into nss3.dll, it still has to import NSPR symbols. Same for freebl3.dll and softokn3.dll.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emk, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Masatoshi Kimura [:emk]]

I have withdrawn the patch until the problem described in comment #5 is resolved.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 9

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.