16844 - alt keys insert a space

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Akkana Peck]

The (vaporware :-) key event spec says that control, shift, alt and meta keys
generate a KeyPress event just like any other key.  But the editor happily
inserts these key events which have a key code and no char code (at least, it
does for the alt key), rendering the key as a space.

I'm attaching a patch that fixes the problem.  However, the fact that no one on
Windows or Mac has noticed this makes me wonder whether those platforms can
actually generate this event which the spec calls for.  Kathy, Saari, Frank, can
you check Mac and Windows and find out?  Meanwhile, Kathy, can you please try
the attached patch, and code review it?

Comment 1

[Akkana Peck]

Attachment: Patch for the editor to make it not insert modifier key events

Comment 2

[Stuart Parmenter]

this fixes the problem for me.

Comment 3

[Kathleen :Brade]

This patch is incomplete; it does not look for the Meta key.  If you add that
check I approve.

At some point I was planning to add inside an #ifdef DEBUG block an assert if we
ever are trying to insert a charcode of 0.  This should help us track down
problems a little quicker.

Btw, Mac and Windows don't adhere to the modifier-only part of the spec yet.
Frank and I decided that it wasn't critical enough to hold the branch landing
since no one needs that functionality in the current product.

Comment 4

[Akkana Peck]

Fixed.

Comment 5

[sujay]

verified in 10/21 build.