Closed Bug 1684423 Opened 4 years ago Closed 4 years ago

Misalignment in account settings

Categories

(Thunderbird :: Account Manager, defect, P5)

Thunderbird 86
x86_64
Linux

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
86 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: twinshadows404, Assigned: Paenglab)

References

Details

Attachments

(3 files, 1 obsolete file)

Attached image thunderbird.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

Go under Account Settings> Outgoing Server(SMTP)

Actual results:

Connection Security is out of bounds.

Expected results:

Connection Security should be in bounds.

Severity: -- → S4
Component: Untriaged → Account Manager
Attached image Account-Settings.png

I'm not seeing any problem on Ubuntu 18.04 LTS.
Name Thunderbird
Version 86.0a1
Build ID 20201229105507

It appears to me by the cutoff text at the top of their image that the reporter's window was resized, and they had to use the scrollbar to see Connection Security.

Hello, I fiddled with the settings a bit more and found out that the front size is causing the issue.
I'm using redhat text 14 as scaling still doesn't work well, at least on Plasma.

Changing the size back to stock fixes the issue.

(In reply to twinshadows404 from comment #2)

Hello, I fiddled with the settings a bit more and found out that the front size is causing the issue.
I'm using redhat text 14 as scaling still doesn't work well, at least on Plasma.

Changing the size back to stock fixes the issue.

Thanks for the update.

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME

But it doesn't work for me as fonts look tiny with the default settings on a 1440p screen.
Using higher size fonts shouldn't break the app.

Status: RESOLVED → UNCONFIRMED
OS: Unspecified → Linux
Priority: -- → P5
Hardware: Unspecified → x86_64
Resolution: WORKSFORME → ---

Using a table instead of a needless stack and a HBOX with VBOXes.

Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9194891 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9194891 [details] [diff] [review] 1684423-smtpServerInfoBox-table.patch Review of attachment 9194891 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/themes/shared/mail/accountManage.css @@ +9,5 @@ > @import url("chrome://messenger/skin/messenger.css"); > @import url("chrome://global/skin/in-content/common.css"); > @import url("chrome://messenger/skin/preferences/preferences.css"); > > +@namespace html url("http://www.w3.org/1999/xhtml"); since there is no default namespace here, I *think* you can also avoid the namespace and just use un-prefixed th td etc. ::: mailnews/base/prefs/content/am-smtp.xhtml @@ +57,5 @@ > </hbox> > > <separator/> > > <label class="header">&serverDetails.label;</label> Preferably this should be html:caption, inside the table @@ +58,5 @@ > > <separator/> > > <label class="header">&serverDetails.label;</label> > + <html:table id="smtpServerInfoBox"> wrong indention it seems @@ +70,5 @@ > + type="text" > + readonly="readonly" > + class="plain" > + aria-labelledby="descriptionLabel"/> > + </html:td> Since none of these really need to be input, other than to be selectable, I'd just change the structure (and add some `user-select: all;` <html:th id="descriptionLabel>&serverDescription.label;</html:th> <html:td id="descriptionValue></html:td> ... and similar for all the rest. https://searchfox.org/comm-central/rev/290abc2f4584c108051881abef139fcc243b92ae/mailnews/base/prefs/content/am-smtp.js#129 would have to be .textContent instead of .value
Attachment #9194891 - Flags: review?(mkmelin+mozilla) → feedback+

Followed the proposals. Haven't used user-select: all; as is selects the text but it's not copyable. It would also not make much sense to let it copy from there as this would be the only such area in the prefs. The values can also be copied in the settings dialog or the Troubleshooting Informations.

Attachment #9194891 - Attachment is obsolete: true
Attachment #9194933 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9194933 [details] [diff] [review] 1684423-smtpServerInfoBox-table.patch Review of attachment 9194933 [details] [diff] [review]: ----------------------------------------------------------------- Great, thx! r=mkmelin
Attachment #9194933 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → 86 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/2ef57903242b
Use a table for the smtpServerInfoBox. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Regressions: 1689247
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: