1684490 - [fission] External protocol opening dialog doesn't work on a cross-origin iframe.

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

STR:

• Go to http://crisal.io/tmp/fission-external-protocol-link.html
• Confirm that you're using a cross-origin iframe (the page should print it)
• Click on the link.

ER:

• A dialog that shows "Allow https://crisal.io to open the magnet link?", then a dialog to choose application, etc.

AR:

• Nothing

I found this on the wild so we should probably fix it.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I guess I've touched the area recently so I'll poke.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684490 - Check an in-process window context for user interaction. r=smaug,edgar

In the case we click a link from inside the frame, we don't want to
check for activation from the parent window but ourselves.

It feels like using the sourceWindowContext for these checks is always
the right thing to do, but it's not always possible if we set the
location.href from an out-of-process parent. In this case, we fall back
to consuming user activation on the iframe itself. This is tested in
browbrowser_protocol_ask_dialog.js when run with fission enabled.

We could consider making the user activation stuff more
multiprocess-friendly, but it's not clear to me it's worth it for this
particular edge case.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684490 - Make some BrowsingContext/WindowContext asserts DIAGNOSTIC_ASSERTS. r=smaug,edgar,nika

These would've caught the issue a lot sooner.

Depends on D100578

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1679456

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I'm not seeing anything when clicking the link even when using 84 without Fission.
Bug 1679456 landed 85.
Am I missing something?

Comment 6

[Emilio Cobos Álvarez (:emilio)]

You probably need an application that handles magnet: links (or changing the link to some other protocol).

Comment 7

[Chris Peterson [:cpeterson]]

status-firefox85: --- → affected

The Release Management bot marked this bug as affecting Fx85 Beta (because the regressing Bug 1679456 landed in Fx85 Nightly). But if this bug is only reproducible with Fission, we won't need to uplift the fix to Beta.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ad6088bb2c2
Check an in-process window context for user interaction. r=smaug,edgar DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/1f44b3e9ec62
Make some BrowsingContext/WindowContext asserts DIAGNOSTIC_ASSERTS. r=edgar DONTBUILD

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bf6c172cbec
Backed out 2 changesets as per emilio`s request
https://hg.mozilla.org/integration/autoland/rev/79f33c375935
Check an in-process window context for user interaction. r=smaug,edgar
https://hg.mozilla.org/integration/autoland/rev/7d10fe1f2f2e
Make some BrowsingContext/WindowContext asserts DIAGNOSTIC_ASSERTS. r=edgar

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/79f33c375935
https://hg.mozilla.org/mozilla-central/rev/7d10fe1f2f2e

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/b78714751fcd
Backed out changeset 7d10fe1f2f2e for causing bug 1685106. a=backout DONTBUILD