1684581 - Calendar views not resizing correctly

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Geoff Lankow (:darktrojan)]

I've had the week view open lately (instead of multi-week) and I noticed that when starting Thunderbird with the calendar tab selected it doesn't lay out correctly straight away. Investigating this I noticed it doesn't take any notice of the window size changing.

Once I fixed that I noticed that when onResize runs on all of the views in most cases, which is pointless for views that aren't visible because onResize is called when the view changes.

I also noticed that toggling the unifinder doesn't cause the views to lay out.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1684581 - Fix and tidy up resizing of calendar views. r?mkmelin

Simplifies the "viewresized" event. Fires the event when the unifinder size changes. Only runs onResized() on the current view.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dade8e2a6fab
Fix and tidy up resizing of calendar views. r=mkmelin

Comment 3

[Magnus Melin [:mkmelin]]

I think this is causing the bct1 failures "TEST-UNEXPECTED-FAIL | comm/mail/base/test/performance/browser_preferences_usage.js | intl.regional_prefs.use_os_locales should be accessed at most 120 times. - 134 <= 120 - JS frame :: chrome://mochitests/content/browser/comm/mail/base/test/performance/browser_preferences_usage.js :: checkPrefGetters :: line 63"

... due to more access after the fix.

Comment 4

[Geoff Lankow (:darktrojan)]

You're right, but why? Investigating…

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1684581 follow-up - Avoid resizing calendar views where possible. r?mkmelin

If the calendar tab is not shown, or a viewresize event happens but the current view is still the same size, we can avoid doing any layout calculation.

This fixes the failing test but still performs the layout operation when the calendar tab becomes selected.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/85c460d4e446
follow-up - Avoid resizing calendar views where possible. r=mkmelin

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1684581-resize-calendar-views-esr78.diff

[Approval Request Comment]
User impact if declined: calendar views aren't expanded/contracted to fit the space available in some situations
Testing completed (on c-c, etc.): in beta 86
Risk to taking this patch (and alternatives if risky): I don't think so

(This rebased patch and the follow-up which doesn't need rebasing.)

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9205349 [details] [diff] [review]
1684581-resize-calendar-views-esr78.diff

[Triage Comment]
Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.8.1:
https://hg.mozilla.org/releases/comm-esr78/rev/064bf8c4e00d

Comment 10

[Geoff Lankow (:darktrojan)]

The follow-up patch was supposed to be uplifted too, I must not have made that clear enough. However I've just discovered it is faulty, so not being uplifted was a good thing.