1684764 - startup Crash in [@ mozilla::detail::nsTStringRepr<T>::First | nsMsgComposeService::Handle] via nsCommandLine

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Wayne Mery (:wsmwk)]

Crash report: https://crash-stats.mozilla.org/report/index/93a350f8-2e4d-4733-98ff-f9fa90210103

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(this->mLength > 0) (|First()| called on an empty string)

Top 10 frames of crashing thread:

0 xul.dll mozilla::detail::nsTStringRepr<char16_t>::First const xpcom/string/nsTSubstring.cpp:943
1 xul.dll nsMsgComposeService::Handle comm/mailnews/compose/src/nsMsgComposeService.cpp:1375
2 xul.dll EnumRun toolkit/components/commandlines/nsCommandLine.cpp:490
3 xul.dll nsCommandLine::EnumerateHandlers toolkit/components/commandlines/nsCommandLine.cpp:445
4 xul.dll nsCommandLine::Run toolkit/components/commandlines/nsCommandLine.cpp:500
5 xul.dll XREMain::XRE_mainRun toolkit/xre/nsAppRunner.cpp:4593
6 xul.dll XREMain::XRE_main toolkit/xre/nsAppRunner.cpp:4812
7 xul.dll XRE_main toolkit/xre/nsAppRunner.cpp:4866
8 xul.dll mozilla::BootstrapImpl::XRE_main toolkit/xre/Bootstrap.cpp:45
9 thunderbird.exe NS_internal_main comm/mail/app/nsMailApp.cpp:324

Comment 1

[Magnus Melin [:mkmelin]]

Fixing the crash per se would be easy. But takes some figuring out what this code is really supposed to do or not.
Crashes at https://searchfox.org/comm-central/rev/d2d1e5d5d857bafbb63e341903ba899eaf38c574/mailnews/compose/src/nsMsgComposeService.cpp#1378

Comment 2

[Wayne Mery (:wsmwk)]

Crash rate dropped 80-90% in April. Perhaps with 78.9.1. Or some other change.

Comment 3

[Wayne Mery (:wsmwk)]

bp-838b34fe-bb79-4f9d-a0d0-610990210822 91.0.1
0 xul.dll mozilla::detail::nsTStringRepr<char16_t>::First() const xpcom/string/nsTSubstring.cpp:968
1 xul.dll nsMsgComposeService::Handle(nsICommandLine*) comm/mailnews/compose/src/nsMsgComposeService.cpp:1386
2 xul.dll nsCommandLine::EnumerateHandlers(nsresult ()(nsICommandLineHandler, nsICommandLine*, void*), void*) toolkit/components/commandlines/nsCommandLine.cpp:466
3 xul.dll nsCommandLine::Run() toolkit/components/commandlines/nsCommandLine.cpp:521
4 xul.dll XREMain::XRE_mainRun() toolkit/xre/nsAppRunner.cpp:5151
5 xul.dll XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) toolkit/xre/nsAppRunner.cpp:5434

Comment 4

[Wayne Mery (:wsmwk)]

version 91 is still virtually zero.

version 78.14.0 example mozilla::detail::nsTStringRepr<T>::First | nsMsgComposeService::Handle bp-b60e43f3-ce76-4313-b021-623f80211109
0 xul.dll mozilla::detail::nsTStringRepr<char16_t>::First() const
1 xul.dll nsMsgComposeService::Handle(nsICommandLine*)
2 xul.dll EnumRun(nsICommandLineHandler*, nsICommandLine*, void*)
3 xul.dll nsCommandLine::EnumerateHandlers(nsresult ()(nsICommandLineHandler, nsICommandLine*, void*), void*)
4 xul.dll nsCommandLine::Run()
5 xul.dll WindowProc(HWND__, unsigned int, unsigned int, long)
6 user32.dll _InternalCallWinProc
7 user32.dll long __stdcall UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT, void*, struct HWND__, enum _WM_VALUE, unsigned int, long, void, int)
8 user32.dll DispatchClientMessage
9 user32.dll _fnCOPYDATA
10 ntdll.dll KiUserCallbackDispatcher
11 ntdll.dll KiUserApcDispatcher
12 user32.dll PeekMessageW
13 msctf.dll virtual long stdcall CThreadInputMgr::PeekMessageW(struct tagMSG*, struct HWND, unsigned int, unsigned int, unsigned int, int)

Comment 5

[Wayne Mery (:wsmwk)]

Still rare in the last 6 months, with no version 128 crashes for linux, and the only two windows are from the same person who has bitdefender addon installed.

So closing this WFM

Comment 6

[Magnus Melin [:mkmelin]]

One of the top crashes now (though not many crashes)

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: Bug 1684764 - Fix crash in [@ mozilla::detail::nsTStringRepr<T>::First | nsMsgComposeService::Handle] via nsCommandLine. r=#thunderbird-back-end-reviewers

Happens e.g. with thunderbird -compose mailto:[e-mail] ""

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/93a6a10aed3d
Fix crash in [@ mozilla::detail::nsTStringRepr<T>::First | nsMsgComposeService::Handle] via nsCommandLine. r=edicharry

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9508168 [details]
Bug 1684764 - Fix crash in [@ mozilla::detail::nsTStringRepr<T>::First | nsMsgComposeService::Handle] via nsCommandLine. r=#thunderbird-back-end-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Crash fix
• User impact if declined: May crash
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple crash fix
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 10

[Corey Bryant]

Comment on attachment 9508168 [details]
Bug 1684764 - Fix crash in [@ mozilla::detail::nsTStringRepr<T>::First | nsMsgComposeService::Handle] via nsCommandLine. r=#thunderbird-back-end-reviewers

[Triage Comment]
Approved for beta

Comment 11

[Corey Bryant]

Comment on attachment 9508168 [details]
Bug 1684764 - Fix crash in [@ mozilla::detail::nsTStringRepr<T>::First | nsMsgComposeService::Handle] via nsCommandLine. r=#thunderbird-back-end-reviewers

[Triage Comment]
This will be included in Monday's merge of central->beta

Comment 12

[Corey Bryant]

Comment on attachment 9508168 [details]
Bug 1684764 - Fix crash in [@ mozilla::detail::nsTStringRepr<T>::First | nsMsgComposeService::Handle] via nsCommandLine. r=#thunderbird-back-end-reviewers

[Triage Comment]
Approved for esr140

Comment 13

[Stephen King (:sking)]

Thunderbird 140.3.1esr:
https://hg.mozilla.org/releases/comm-esr140/rev/eca2ca04368abd4afe662f2862616b1bd5fa6642