Closed Bug 1685061 Opened 3 months ago Closed 2 months ago

Localization new Performance panel onboarding component

Categories

(DevTools :: Performance Tools (Profiler/Timeline), task, P3)

task

Tracking

(Fission Milestone:M7, firefox87 fixed)

RESOLVED FIXED
87 Branch
Fission Milestone M7
Tracking Status
firefox87 --- fixed

People

(Reporter: Honza, Assigned: nchevobbe)

References

Details

(Whiteboard: dt-fission-m3-mvp )

Attachments

(1 file, 1 obsolete file)

The new Performance panel should be properly localized just like all the other DevTools panels.

Honza

Whiteboard: dt-fission-m3-mvp

Tracking dt-fission-m3-mvp bugs for Fission M8 (blocking Release channel experiment, but not Beta experiment).

Fission Milestone: --- → M8

Potential duplicate of Bug 1599774 (at least most of the panel seems to be localized in this bug).

Depends on: 1599774

Repurposing to localize the onboarding component of the new perf-panel. All the other components seem handled in Bug 1599774

See https://searchfox.org/mozilla-central/source/devtools/client/performance-new/components/OnboardingMessage.js

Summary: Localization support for the new Performance panel → Localization new Performance panel onboarding component

Moving dt-fission-m3-mvp bugs from Fission M8 to M7 (blocking Beta experiment).

Fission Milestone: M8 → M7

Let's give this a try

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Depends on: 1690834
No longer depends on: 1690834

We add a few localized string in perftools.ftl to replace to hardcoded labels
in the component.
This allows us to simplify the structure of the component.
We take this opportunity to re-use the localized string we have to link to the
advanced section of the settings panel.

We add a few localized string in perftools.ftl to replace to hardcoded labels
in the component.
This allows us to simplify the structure of the component.
We take this opportunity to re-use the localized string we have to link to the
advanced section of the settings panel.

Attachment #9201334 - Attachment is obsolete: true
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2443341cb252
[devtools] Localize new perf panel onboarding UI. r=julienw,flod.
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/734d6233d1cd
Remove trailing whitespace in en-US/perftools.ftl for causing lint failures. a=lint-fix
Flags: needinfo?(nchevobbe)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65e404832d37
[devtools] Localize new perf panel onboarding UI. r=julienw,flod.
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57cb40f78ccc
[devtools] Localize new perf panel onboarding UI. r=julienw,flod.

this patch should be fine, Bug 1668218 is most likely the offender

Flags: needinfo?(nchevobbe)
Status: REOPENED → RESOLVED
Closed: 2 months ago2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Depends on: 1693730
You need to log in before you can comment on or make changes to this bug.