1685061 - Localization new Performance panel onboarding component

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The new Performance panel should be properly localized just like all the other DevTools panels.

Honza

Comment 1

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m3-mvp bugs for Fission M8 (blocking Release channel experiment, but not Beta experiment).

Comment 2

[Julian Descottes [:jdescottes]]

Potential duplicate of Bug 1599774 (at least most of the panel seems to be localized in this bug).

Comment 3

[Julian Descottes [:jdescottes]]

Repurposing to localize the onboarding component of the new perf-panel. All the other components seem handled in Bug 1599774

See https://searchfox.org/mozilla-central/source/devtools/client/performance-new/components/OnboardingMessage.js

Comment 4

[Chris Peterson [:cpeterson]]

Moving dt-fission-m3-mvp bugs from Fission M8 to M7 (blocking Beta experiment).

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Let's give this a try

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1685061 - [devtools] Localize new perf panel onboarding UI. r=julienw.

We add a few localized string in perftools.ftl to replace to hardcoded labels
in the component.
This allows us to simplify the structure of the component.
We take this opportunity to re-use the localized string we have to link to the
advanced section of the settings panel.

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1685061 - [devtools] Localize new perf panel onboarding UI. r=julienw.

We add a few localized string in perftools.ftl to replace to hardcoded labels
in the component.
This allows us to simplify the structure of the component.
We take this opportunity to re-use the localized string we have to link to the
advanced section of the settings panel.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2443341cb252
[devtools] Localize new perf panel onboarding UI. r=julienw,flod.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/734d6233d1cd
Remove trailing whitespace in en-US/perftools.ftl for causing lint failures. a=lint-fix

Comment 10

[Narcis Beleuzu [:NarcisB]]

Backed out for dt failures on browser_aboutdebugging_devtoolstoolbox_reload.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/7d089aec8ffc916de4961193bf33c67f4a36aebf
Log link: https://treeherder.mozilla.org/logviewer?job_id=329516875&repo=autoland&lineNumber=2722

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65e404832d37
[devtools] Localize new perf panel onboarding UI. r=julienw,flod.

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/65e404832d37

Comment 13

[Atila Butkovits]

Backed out for causing failures on browser_aboutdebugging_devtoolstoolbox_reload.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8afd66ac13397d2127f9c5ea74d298d74d5fdcdb

Failures start here: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=XPLJBljPS36ruJOatYusrA.0&searchStr=OS%2CX%2C10.14%2CWebRender%2Cdebug%2CMochitests%2Ctest-macosx1014-64-qr%2Fdebug-mochitest-devtools-chrome-e10s%2Cdt4&revision=e602ff8fea8362db48bafff91ac6a127a82b0836

Failure log: https://treeherder.mozilla.org/logviewer?job_id=329606145&repo=autoland&lineNumber=6209

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/8afd66ac1339

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57cb40f78ccc
[devtools] Localize new perf panel onboarding UI. r=julienw,flod.

Comment 16

[Nicolas Chevobbe [:nchevobbe]]

this patch should be fine, Bug 1668218 is most likely the offender

Comment 17

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/57cb40f78ccc