1685104 - Follow the tree for coloring the attachmentItems

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

We should follow the treechildren for the colouring of the attachmentItems.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1685104-attachmentItem-color.patch

I moved the content/attachmentList.css to the shared theme files and unified some code from messageHeader.css and messengercompose to attachmentList.css.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1685104-attachmentItem-color.patch

Found a small issue on macOS with dark theme and inactive window.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9195451 [details] [diff] [review]
1685104-attachmentItem-color.patch

Review of attachment 9195451 [details] [diff] [review]:
-----------------------------------------------------------------

Great clean up!
I think we should boost the opacity of the .attachmentcell-size element to 0.8 when the item is selected to guarantee proper readability contrast.

::: mail/themes/shared/mail/messenger.css
@@ +79,5 @@
>    --button-background-hover: #575758;
>    --button-background-active: #626263;
>    --button-border-color: #626263;
> +
> +  --item-focus-selected-border-color: rgb(249, 249, 250);

This feels a little bit too bright in dark mode.
What do you think about a full white at .75 opacity?

Comment 4

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani (:aleca) from comment #3)

::: mail/themes/shared/mail/messenger.css
@@ +79,5 @@

--button-background-hover: #575758;
--button-background-active: #626263;
--button-border-color: #626263;
+

• --item-focus-selected-border-color: rgb(249, 249, 250);

This feels a little bit too bright in dark mode.
What do you think about a full white at .75 opacity?

This is what we have already. I moved it only to the variable. I can do it less bright but I think we should also change the border for the light/default theme to be darker because with only one selected item the border is almost invisible on the white tree background.

What do you think?

Comment 5

[Alessandro Castellani [:aleca]]

Yes, sounds good

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1685104-attachmentItem-color.patch

Changed the border colours and added the rule for opacity: 0.8 when the attachmentItem is selected and has focus.

Comment 7

[Alessandro Castellani [:aleca]]

Comment on attachment 9195485 [details] [diff] [review]
1685104-attachmentItem-color.patch

Review of attachment 9195485 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/166fda7c1d87
Follow the tree for coloring the attachmentItems. r=aleca