Closed Bug 1685105 Opened 3 months ago Closed 1 month ago

XHR Breakpoint should work in remote frames

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(Fission Milestone:M7, firefox88 fixed)

RESOLVED FIXED
88 Branch
Fission Milestone M7
Tracking Status
firefox88 --- fixed

People

(Reporter: Honza, Assigned: ochameau)

References

(Blocks 3 open bugs)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file)

XHR breaktpoint should work even when XHR is executed from within remote frame.

STR:

  1. Load http://janodvarko.cz/tests/fission/case1/index.html
  2. Open DevTools and select the Debugger panel
  3. Check "Pause on any URL"
  4. Click the POST button in the remote frame
  5. The debugger should pause JS execution

Note that XHR BP works when HTTP is executed from top level document.

Honza

Tracking dt-fission-m3-mvp bugs for Fission M8 (blocking Release channel experiment, but not Beta experiment).

Fission Milestone: --- → M8

It is very likely related to the same issue described in bug 1602488 comment 1.

I see two ways to fix that:

  • Have Debugger frontend to loop over all Target's threadFront and call setXHRBreakpoint on all thread fronts, including the one for the remote frames.
  • Pass XHR breakpoints via the watcher actor, like what we did for regular breakpoints in bug 1573327.

The second option is better as it would also ensure breaking on XHR during early page load.

Blocks: 1687261

Moving dt-fission-m3-mvp bugs from Fission M8 to M7 (blocking Beta experiment).

Fission Milestone: M8 → M7
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5199ec2d73fa
[devtools] Pass XHR breakpoint via the Watcher Actor. r=nchevobbe,bomsy,devtools-backward-compat-reviewers
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.