Closed Bug 1685192 Opened 2 years ago Closed 2 months ago

WebRender profiler threads are not enabled on WebRender raptor try builds

Categories

(Testing :: Raptor, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: gw, Unassigned)

References

(Blocks 1 open bug)

Details

When running a raptor try build with webrender and generating a gecko profile, the webrender specific threads are not added to the list of threads to be sampled by the gecko profiler.

See [1] for an example of the job I'm trying to run.

I patched the code at [2] to unconditionally add these threads, and a try run with that does sample those extra webrender threads.

So it seems that the environment variable at [2] is not being set in this configuration?

[1] https://treeherder.mozilla.org/jobs?repo=try&revision=6c9cc5deb7c5396301474d0c98f2bf4151a91ca4&selectedTaskRun=L-soTMRvQQ2yuwFrMnNReg.0
[2] https://searchfox.org/mozilla-central/source/testing/raptor/raptor/manifest.py#296

Component: General → Raptor
Product: Firefox Build System → Testing
Severity: -- → S3
Priority: -- → P2

Hi Gerald,
Is this still an issue in the profiler?

Flags: needinfo?(gsquelart)

Nazim, you're looking into profiling tests at the moment, could you please help with this, or know someone who would know?

Flags: needinfo?(gsquelart) → needinfo?(canaltinova)

(sorry for the delay)

For the record, two years ago the searchfox url was pointing this line: https://searchfox.org/mozilla-central/rev/9ff67db626176adbbda52246c38dbd795e82b257/testing/raptor/raptor/manifest.py#248-250

Before webrender was the default one, apparently we were using this MOZ_WEBRENDER variable to conditionally add additional webrender threads. But this conditional check is removed in: https://hg.mozilla.org/mozilla-central/rev/45963c59dfa731b379e0b682bba0f9920b3f5e83 (Bug 1743907)
Now they are being added unconditionally: https://searchfox.org/mozilla-central/rev/43ba67391e71c57a14420e554e9d381543292611/testing/raptor/raptor/manifest.py#246

Even though that threads.extend line is unnecessary (we can just append the items to the line above), it seems like this issue is fixed now since we don't look for that environment variable. We can close this bug.

Status: NEW → RESOLVED
Closed: 2 months ago
Flags: needinfo?(canaltinova)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.