1685298 - Perma build bustage dom/cache/FileUtilsImpl.h:90:10: error: variable 'rv' is uninitialized when used here [-Werror,-Wuninitialized] when Gecko 86 merges to Beta on 2021-01-25

Status: VERIFIED FIXED

(Core :: Storage: Cache API, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central-as-beta simulation
Failure Log

[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/dom/cache'
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o Unified_cpp_dom_cache1.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -fno-common -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/cache -I/builds/worker/workspace/obj-build/dom/cache -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fsanitize=bool,bounds,enum,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fno-sanitize-recover=bool,bounds,enum,integer-divide-by-zero,object-size,pointer-overflow,return,vla-bound -fsanitize-blacklist=/builds/worker/workspace/obj-build/ubsan_blacklist.txt -fsanitize=address -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -gline-tables-only -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow  -MD -MP -MF .deps/Unified_cpp_dom_cache1.o.pp   Unified_cpp_dom_cache1.cpp
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  In file included from Unified_cpp_dom_cache1.cpp:29:
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  In file included from /builds/worker/checkouts/gecko/dom/cache/FileUtils.cpp:7:
[task 2021-01-06T13:09:04.220Z] 13:09:04    ERROR -  /builds/worker/checkouts/gecko/dom/cache/FileUtilsImpl.h:90:10: error: variable 'rv' is uninitialized when used here [-Werror,-Wuninitialized]
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -    return rv;
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -           ^~
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  /builds/worker/checkouts/gecko/dom/cache/FileUtils.cpp:385:10: note: in instantiation of function template specialization 'mozilla::dom::cache::BodyTraverseFiles<(lambda at /builds/worker/checkouts/gecko/dom/cache/FileUtils.cpp:364:9)>' requested here
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -      rv = BodyTraverseFiles(aQuotaInfo, bodyDir, removeFileForId,
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -           ^
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  /builds/worker/checkouts/gecko/dom/cache/FileUtilsImpl.h:22:3: note: variable 'rv' is declared here
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -    nsresult rv;
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -    ^
[task 2021-01-06T13:09:04.220Z] 13:09:04    ERROR -  /builds/worker/checkouts/gecko/dom/cache/FileUtilsImpl.h:90:10: error: variable 'rv' is uninitialized when used here [-Werror,-Wuninitialized]
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -    return rv;
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -           ^~
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  /builds/worker/checkouts/gecko/dom/cache/FileUtils.cpp:547:19: note: in instantiation of function template specialization 'mozilla::dom::cache::BodyTraverseFiles<(lambda at /builds/worker/checkouts/gecko/dom/cache/FileUtils.cpp:510:3)>' requested here
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -          CACHE_TRY(BodyTraverseFiles(aQuotaInfo, subdir, removeOrphanedFiles,
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -                    ^
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  /builds/worker/checkouts/gecko/dom/cache/FileUtilsImpl.h:22:3: note: variable 'rv' is declared here
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -    nsresult rv;
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -    ^
[task 2021-01-06T13:09:04.220Z] 13:09:04    ERROR -  /builds/worker/checkouts/gecko/dom/cache/FileUtilsImpl.h:90:10: error: variable 'rv' is uninitialized when used here [-Werror,-Wuninitialized]
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -    return rv;
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -           ^~
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  /builds/worker/checkouts/gecko/dom/cache/QuotaClient.cpp:102:19: note: in instantiation of function template specialization 'mozilla::dom::cache::BodyTraverseFiles<(lambda at /builds/worker/checkouts/gecko/dom/cache/QuotaClient.cpp:58:3)>' requested here
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -          CACHE_TRY(BodyTraverseFiles(QuotaInfo{}, bodyDir, getUsage,
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -                    ^
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  /builds/worker/checkouts/gecko/dom/cache/FileUtilsImpl.h:22:3: note: variable 'rv' is declared here
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -    nsresult rv;
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -    ^
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  3 errors generated.
[task 2021-01-06T13:09:04.220Z] 13:09:04     INFO -  /builds/worker/checkouts/gecko/config/rules.mk:674: recipe for target 'Unified_cpp_dom_cache1.o' failed
[task 2021-01-06T13:09:04.220Z] 13:09:04    ERROR -  make[4]: *** [Unified_cpp_dom_cache1.o] Error 1

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1685298 - Fix uninitialized variable in non-diagnostic builds. r=#dom-workers-and-storage

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Can you share the ancestor revisions on which was written, please? There is a hunk failure applying the patch (diagnostic assert at start of function got removed) and a manual fix yields build failures for DevEdition and Linux debug.

Comment 3

[Simon Giesecke [:sg] [he/him]]

I rebased the patch now so it shouldn't depend on any other patches implicitly anymore.

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

The patch worked in today's beta simulation.

https://treeherder.mozilla.org/jobs?repo=try&revision=2852daa71adf8235e7787351d2396e4626bb4e7e&searchStr=Linux%2Cx64%2Casan%2Cbuild-linux64-asan%2Fopt%2CBo&selectedTaskRun=VUHfD8mZRqyBZY9NC9FN6g.0

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6dcbd48bd86
Fix uninitialized variable in non-diagnostic builds. r=dom-workers-and-storage-reviewers,ttung

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a6dcbd48bd86

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with latest central-to-beta simulation.