Closed
Bug 1685353
Opened 3 years ago
Closed 3 years ago
Disable "-Woverloaded-virtual" for GCC, because it warns on static overloads
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox86 fixed)
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: mhentges, Assigned: mhentges)
References
Details
Attachments
(1 file)
After some discussion with :andi, it sounds like the case made here isn't quite accurate. As confirmed by :andi:
It's impossible to override a virtual method statically, so this shouldn't be a surprise to C++ developers
It sounds like this warning isn't valuable.
So, rather than making this into a clang-tidy warning as described here, we will disable this warning on GCC so that developers aren't bugged by delayed backouts.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → mhentges
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•3 years ago
|
||
In addition to warning on regular methods overloading virtual functions,
GCC also watches for static functions doing such overloads.
:andi confirmed that this is not valuable, so the warning is being
disabled for GCC.
Pushed by mhentges@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec3d60a61867 Disable -Woverloaded-virtual for GCC r=firefox-build-system-reviewers,sheehan,andi,glandium
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•