Closed Bug 1685422 Opened 6 months ago Closed 3 months ago

Re-enable test_ext_web_accessible_resources.html and test_ext_web_accessible_incognito.html tests for Fission

Categories

(WebExtensions :: General, task, P2)

task

Tracking

(Fission Milestone:M8, firefox89 fixed)

RESOLVED FIXED
89 Branch
Fission Milestone M8
Tracking Status
firefox89 --- fixed

People

(Reporter: cpeterson, Assigned: zombie)

References

(Blocks 4 open bugs)

Details

Attachments

(1 file)

The test_ext_web_accessible_resources.html and test_ext_web_accessible_incognito.html tests are currently skipped for Fission (by bug 1618231 and bug 1588284) for intermittent CreateFromIPC crashes.

Nika fixed some CreateFromIPC crashes (in bug 1580565), so perhaps these tests no longer crash and can be re-enabled now.

[test_ext_web_accessible_resources.html]
skip-if = (os == 'android' && debug) || fission || (os  == "linux" && bits == 64) # bug 1397615, bug 1588284, bug 1618231
[test_ext_web_accessible_incognito.html]
skip-if = (os == 'android') || fission # Crashes intermittently: @ mozilla::dom::BrowsingContext::CreateFromIPC(mozilla::dom::BrowsingContext::IPCInitializer&&, mozilla::dom::BrowsingContextGroup*, mozilla::dom::ContentParent*), bug 1588284, bug 1397615 and bug 1513544

https://searchfox.org/mozilla-central/rev/ef900cd2258d4c5d968093f612f807d96e6e7c98/toolkit/components/extensions/test/mochitest/mochitest-common.ini#171-174

Tom, I'm moving these extension tests to the WebExtensions Product. Nika fixed some CreateFromIPC crashes (in bug 1580565), so perhaps these tests no longer crash and can be re-enabled now.

Component: DOM: Content Processes → General
Flags: needinfo?(tomica)
Product: Core → WebExtensions

Thanks Chris, let's try to enable them.

Assignee: nobody → tomica
Severity: -- → N/A
Flags: needinfo?(tomica)
Priority: -- → P2

zombie says re-enabling this test doesn't need to block Fission M7 Beta experiment. I'll move this bug to Fission M8.

Fission Milestone: M7 → M8
Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0dbd0fed0bfa
Enable test_ext_web_accessible_resources and test_ext_web_accessible_incognito with fission r=mixedpuppy
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.