1685422 - Re-enable test_ext_web_accessible_resources.html and test_ext_web_accessible_incognito.html tests for Fission

Status: RESOLVED FIXED

(WebExtensions :: General, task, P2)

Description

[Chris Peterson [:cpeterson]]

The test_ext_web_accessible_resources.html and test_ext_web_accessible_incognito.html tests are currently skipped for Fission (by bug 1618231 and bug 1588284) for intermittent CreateFromIPC crashes.

Nika fixed some CreateFromIPC crashes (in bug 1580565), so perhaps these tests no longer crash and can be re-enabled now.

[test_ext_web_accessible_resources.html]
skip-if = (os == 'android' && debug) || fission || (os  == "linux" && bits == 64) # bug 1397615, bug 1588284, bug 1618231
[test_ext_web_accessible_incognito.html]
skip-if = (os == 'android') || fission # Crashes intermittently: @ mozilla::dom::BrowsingContext::CreateFromIPC(mozilla::dom::BrowsingContext::IPCInitializer&&, mozilla::dom::BrowsingContextGroup*, mozilla::dom::ContentParent*), bug 1588284, bug 1397615 and bug 1513544

https://searchfox.org/mozilla-central/rev/ef900cd2258d4c5d968093f612f807d96e6e7c98/toolkit/components/extensions/test/mochitest/mochitest-common.ini#171-174

Comment 1

[Chris Peterson [:cpeterson]]

Tom, I'm moving these extension tests to the WebExtensions Product. Nika fixed some CreateFromIPC crashes (in bug 1580565), so perhaps these tests no longer crash and can be re-enabled now.

Comment 2

[Tomislav Jovanovic :zombie]

Thanks Chris, let's try to enable them.

Comment 3

[Chris Peterson [:cpeterson]]

zombie says re-enabling this test doesn't need to block Fission M7 Beta experiment. I'll move this bug to Fission M8.

Comment 4

[Tomislav Jovanovic :zombie]

Attachment: Bug 1685422 - Enable test_ext_web_accessible_resources and test_ext_web_accessible_incognito with fission

Comment 5

[Tomislav Jovanovic :zombie]

try https://treeherder.mozilla.org/jobs?repo=try&revision=8ff51e4aa67fd3b8da0d4aa051c9149f63b1e63c

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dbd0fed0bfa
Enable test_ext_web_accessible_resources and test_ext_web_accessible_incognito with fission r=mixedpuppy

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0dbd0fed0bfa