1685428 - [css-grid] Note implies losing an aspect-ratio when it shouldn't?

Status: RESOLVED FIXED

(Core :: Layout: Grid, defect)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#5713.

[css-grid] Note implies losing an aspect-ratio when it shouldn't?

• RESOLVED: stretch alignment doesn't disable the aspect ratio. It can distort it if the other axis is constrained

Discussion.

Comment 1

[Daniel Holbert [:dholbert]]

Mats, do you have cycles to look at this (or mentor it if someone else takes it)? For now, it'd be great if you could double-check that this change seems reasonable to you. See details in the csswg-drafts issue (and discussion minutes in the comment https://github.com/w3c/csswg-drafts/issues/5713#issuecomment-755791551 )

There are some existing web-platform tests that require the "old" behavior here, which Ian Kilpatrick (who filed the csswg-drafts issue) has volunteered to fix.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #1)

There are some existing web-platform tests that require the "old" behavior here, which Ian Kilpatrick (who filed the csswg-drafts issue) has volunteered to fix.

(Following up: https://chromium-review.googlesource.com/c/chromium/src/+/2611567 is where Ian is updating these tests.)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1685428 Part 1 - Preserve aspect-ratio when stretching replaced element in grid layout. r?#layout

This patch preserves the aspect-ratio when stretching replaced elements in only
one axis in grid layout, under the condition where the preferred size properties
in both axes behave as 'auto'.

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1685428 Part 2 - Update test expectations. r?#layout

In grid-item-intrinsic-ratio-stretch-001-ref.html and
grid-item-intrinsic-ratio-stretch-004-ref.html, I tweaked the unsafe/safe
keyword for some sub-references to match their counterpart in test files.

The sizes in grid-item-intrinsic-ratio-normal-{001,002,003}-ref.html and
grid-item-video-stretch-002-ref.html are updated via the <script> at the end
of the tests.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f574d956bef
Part 1 - Preserve aspect-ratio when stretching replaced element in grid layout. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/187ec787120a
Part 2 - Update test expectations. r=layout-reviewers,emilio

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6f574d956bef
https://hg.mozilla.org/mozilla-central/rev/187ec787120a