1685484 - redesign nsIMsgFolderListener to use specific types rather than nsISupports

Status: RESOLVED FIXED

(MailNews Core :: Backend, task)

Description

[Magnus Melin [:mkmelin]]

Avoid using nsISupports where possible in nsIMsgFolderListener.idl

https://searchfox.org/comm-central/rev/57c0aa5097805106b46b4d49b8a171077751483f/mailnews/base/public/nsIMsgFolderListener.idl#199 is the last of the nsIArray's in Thunderbird idls (in a comment, but the comment seems correct)

Comment 1

[Ben Campbell]

Attachment: Bug 1685484 - Add nsIMsgFolderListener.msgsJunkStatusChanged() callback. r?mkmelin

This callback replaces the "JunkStatusChanged" variant of the
nsIMsgFolderListener.itemEvent() callback, and uses a concrete array to pass
in messages rather than the old nsIArray-passed-in-via-an-nsISupports-param
trick.

Comment 2

[Ben Campbell]

Attachment: Bug 1685484 - Split nsIMsgFolderListener.itemEvent() into separate methods. r?mkmelin

Depends on D112494

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dec533c8f718
Add nsIMsgFolderListener.msgsJunkStatusChanged() callback. r=mkmelin
https://hg.mozilla.org/comm-central/rev/31e99dd7762a
Split nsIMsgFolderListener.itemEvent() into separate methods. r=mkmelin

Comment 4

[alta88]

Repair Folder now blows up because the notifyItemEvent there was missed..
Edit: oh I see you're fixing it in a bug that hasn't landed yet.

Comment 5

[Ben Campbell]

Attachment: Bug 1685484 - Update folder repair to use new notification callbacks. r?darktrojan

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2fc23bba25ec
Update folder repair to use new notification callbacks. r=darktrojan

Comment 7

[John Bieling (:TbSync)]

There is a left over mentioning of nsIFolderListener::itemEvent() in
https://searchfox.org/comm-central/rev/7923bcceab6029d38d0be76a021424b300997dbe/mailnews/base/public/nsIMsgFolderListener.idl#206-210
which I think was removed by this bug.

Should it be replaced by

This notification will be generated immediately prior to the nsIFolderListener::NotifyCompactCompleted() notification.

?

Comment 8

[Ben Campbell]

Thanks John!
I opened up Bug 1780703 for a small fix.
Also led me to spot a potentially more serious issue which I wrote up Bug 1780658.