Closed Bug 1685540 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 27076 - Move CSPEE to the NavigationRequest.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27076 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27076
Details from upstream follow.

b'arthursonzogni <arthursonzogni@chromium.org>' wrote:

Move CSPEE to the NavigationRequest.

Move CSPEE code from the AncestorThrottle toward the NavigationRequest.
Why?

  1. AncestorThrottle is a NavigationThrottle. NavigationThrottle doesn't
    run for several URLs like about:blank. This fixes two two test case
    introduced recently for bug 1163174

  2. CSPEE can add a 'sandbox' directive. This might modify the origin.
    The origin needs to be computed before running the
    NavigationThrottle. So this isn't possible to check CSPEE in the
    NavigationThrottle. Taking CSPEE into accounts for sandbox will be
    fixed in a follow-up.

Bug: 1163174
Change-Id: I193d7821b7819339912a6ba92bdb28e8fa893256
Reviewed-on: https://chromium-review.googlesource.com/2611269
WPT-Export-Revision: cbce870fd59bf404efe31f54a806fc6f37b4c8c4

PR 27076 applied with additional changes from upstream: b7c0a3e0b78b98c2da7526aaa607e25c2110fff6
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
PASS : 1
FAIL : 6

Chrome

TIMEOUT: 2
NOTRUN : 6

Safari

OK : 1
PASS : 1
FAIL : 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/browsers/sandboxing/sandbox-inherited-from-required-csp.html
initial empty document: FAIL (Chrome: TIMEOUT, Safari: FAIL)
about:blank: FAIL (Chrome: NOTRUN, Safari: FAIL)
srcdoc: FAIL (Chrome: NOTRUN, Safari: FAIL)
blob URL: FAIL (Chrome: NOTRUN, Safari: FAIL)
same-origin: FAIL (Chrome: NOTRUN, Safari: FAIL)
cross-origin: FAIL (Chrome: NOTRUN, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3974ed6b632b [wpt PR 27076] - Move CSPEE to the NavigationRequest., a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.