1685806 - Remove expired Telemetry probe telemetry.about_telemetry_pageload

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P3)

Description

[Chris H-C :chutten]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions:
3. Start working on this bug. You will need to remove these lines in toolkit/components/telemetry/Scalars.yaml and this line in toolkit/content/aboutTelemetry.js
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test toolkit/components/telemetry/tests/. Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Comment 1

[Dhanesh]

hey chris,may i work on this?

Comment 2

[Dhanesh]

Attachment: Bug 1685806 Removed the unnecessary lines from telemetry folder

Depends on D100980

Comment 3

[Chris H-C :chutten]

Sorry for the delay in landing your patch. It took a while for me to figure out how to un-parent your patch for bug 163831 (which, since it was marked as Required Revision, prevented me from landing this patch).

With this on its way to being included in Firefox, have you given any thought to what you might like to work on next?

Comment 4

[Dhanesh]

hi chris,Thanks for accepting my patch. i want to participate outreachy'21 mozilla team. Could you tell me which mozilla projects are more likely to get selected for upcoming outreachy program?
Thanks.

Comment 5

[Chris H-C :chutten]

I haven't participated in recent Outreachy rounds, so I'm not sure how to evaluate them. I do know Outreachy Round 21 has already begun (see this timeline). It might be best to ask the folks in the #outreachy channel for more information about Mozilla's involvement in the project.

I can say that the last two times my team mentored for Outreachy we had no problems having our projects selected, and had excellent participants both times, so it seems from my POV that Mozilla projects have a pretty high likelihood of selection. (But my experience is limited and some years old now)

Comment 6

[Chris H-C :chutten]

Oh, which reminds me, did you see the comment on Phabricator? It seems a recent change to Scalars.yaml has made it so Lando can't figure out how to apply your patch. Please rebase and resubmit the patch so I can reland it.

Comment 7

[Dhanesh]

(In reply to Chris H-C :chutten from comment #5)

I haven't participated in recent Outreachy rounds, so I'm not sure how to evaluate them. I do know Outreachy Round 21 has already begun (see this timeline). It might be best to ask the folks in the #outreachy channel for more information about Mozilla's involvement in the project.

I can say that the last two times my team mentored for Outreachy we had no problems having our projects selected, and had excellent participants both times, so it seems from my POV that Mozilla projects have a pretty high likelihood of selection. (But my experience is limited and some years old now)

Ohh ok..thanks Chris for ur nice guidelines.

Comment 8

[Dhanesh]

(In reply to Chris H-C :chutten from comment #6)

Oh, which reminds me, did you see the comment on Phabricator? It seems a recent change to Scalars.yaml has made it so Lando can't figure out how to apply your patch. Please rebase and resubmit the patch so I can reland it.

yea.I see.I tried to resolve the error but some packages need to be installled it seems.Yea I'll do within two days.Thanks

Comment 9

[Dhanesh]

(In reply to Chris H-C :chutten from comment #5)

I haven't participated in recent Outreachy rounds, so I'm not sure how to evaluate them. I do know Outreachy Round 21 has already begun (see this timeline). It might be best to ask the folks in the #outreachy channel for more information about Mozilla's involvement in the project.

I can say that the last two times my team mentored for Outreachy we had no problems having our projects selected, and had excellent participants both times, so it seems from my POV that Mozilla projects have a pretty high likelihood of selection. (But my experience is limited and some years old now)

And could you tell me the projects you were worked on during Outreachy program?Thanks chris

Comment 10

[Chris H-C :chutten]

The ones I remember were adding the "health" ping and something to do with using machine learning techniques to automatically detect regressions in Telemetry data.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kamaraju428, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 13

[Adrian Zhao]

I have attached my patch for bug: Remove or update probes expiring in Firefox 86: COOKIE_SAMESITE_SET_VS_UNSET

Comment 14

[Youhai Li]

I have added the patch and some comments for this bug I would like to work on : https://bugzilla.mozilla.org/show_bug.cgi?id=1672577
Thanks!

Comment 15

[Dhanesh]

@chutten apologies for this long delay. Ive some college stuffs to do in that time. I came to know the thing which caused the lando to land on remote repo. Yea i will do this within no time.

Thanks

Comment 16

[Chris H-C :chutten]

Dhanesh seems to have this one in hand.

Comment 17

[Dhanesh]

have i resolved ur issue? atlast

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e79797db8d4
Removed the unnecessary lines from telemetry folder r=chutten

Comment 19

[Chris H-C :chutten]

Looks like you resolved it! It's now on the autoland repo running some tests. With luck it'll be merged to mozilla-central in time for the next Nightly build that we'll send to our users.

Comment 20

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6e79797db8d4

Comment 21

[Dhanesh]

chutten , one last thing . I got approved to be a part of outreachy . I've decided to record this bug as my contribution . Since i knew only ive removed some lines of code which caused a error in toolkit . But I've to know the background activity what my changes done to the firefox so that i can give a nice description in recording this issue for outreachy.

Thanks

Comment 22

[Chris H-C :chutten]

The background of why this contribution was necessary is this:

• There is a page in Firefox you can reach by putting about:telemetry in the address bar
• We wanted to count how often this was loaded
• We added the Telemetry probe telemetry.about_telemetry_pageload to count that for us, reporting it to Mozilla
• It worked well. We learned that about:telemetry is almost never loaded.
• This probe expired way back in Firefox 70, so it stopped collecting and reporting data
• But the probe still existed in Firefox's code. It took up space in every Firefox being used around the world.

Your change removed the expired probe from Firefox's code, reducing (a little bit) the size of Firefox. It also tidies things up for other developers looking at this code.

Hope this helps!

Comment 23

[Dhanesh]

Thanks chutten .It really helps