Closed Bug 1685809 Opened 3 years ago Closed 3 years ago

Remove expired Scalars `telemetry.profile_directory_scans` and `telemetry.profile_directory_scan_date` and Histogram "PROFILE_DIRECTORY_FILE_AGE"

Categories

(Toolkit :: Telemetry, task, P3)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: chutten, Assigned: aditisingh1400, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=js])

Attachments

(1 file, 4 obsolete files)

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions:
  3. Start working on this bug. You will need to remove these lines in toolkit/components/telemetry/Scalars.yaml, these lines in toolkit/components/telemetry/Histograms.json and these lines in toolkit/modules/ProfileAge.jsm (notice there are three parts of the file highlighted here).
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on Element/Matrix most hours of most days.
  4. Build your change with mach build and test your change with mach test toolkit/components/telemetry/tests/. Also check your changes for adherence to our style guidelines by using mach lint
  5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Hey, Can I work on this bug as my first bug? :)

You certainly may! Please let me know if you have any questions.

Assignee: nobody → aditisingh1400
Status: NEW → ASSIGNED

Depends on D101452

Be sure to abandon the other revisions listed here in the bug (use "Abandon Revision" from the dropdown in Phabricator) so things'll be a bit tidier.

What did you have in mind for your next contribution?

Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa8c4b0a672a
Removed expired Scalars telemetry.profile_directory_scans and telemetry.profile_directory_scan_date and Histogram PROFILE_DIRECTORY_FILE_AGE. r = chutten r=chutten
Attachment #9196568 - Attachment is obsolete: true
Attachment #9196566 - Attachment is obsolete: true
Attachment #9196567 - Attachment is obsolete: true
Attachment #9196564 - Attachment is obsolete: true

(In reply to Chris H-C :chutten from comment #8)

Be sure to abandon the other revisions listed here in the bug (use "Abandon Revision" from the dropdown in Phabricator) so things'll be a bit tidier.

What did you have in mind for your next contribution?

Okay, abandoned the revisions. :). Also, thanks for being so patient all this while.
I am still looking for my next contribution, I think I should still focus on some "good-first-bugs".

You could also widen your search to "good second bugs" or "good next bugs" now that you have a little more familiarity with the tools involved. (I've linked some old searches I had lying around.). They'll be a little more interesting on the coding side.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: