1685833 - pc.restartIce() doesn't work with zero-argument pc.setLocalDescription()

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STRs:

1. Open https://jsfiddle.net/jib1/9Lpdwxrg/
2. Check the first ☑ Camera

   ONN
   gathering
   onicecandidate: dc948bce
   onicecandidate: dc948bce
   onicecandidate: dc948bce
   onicecandidate: dc948bce
   onicecandidate: dc948bce
   complete
   addIceCandidate: d3abc55f
   addIceCandidate: d3abc55f
   addIceCandidate: d3abc55f
   

3. Click the first Restart button

Expected result:

ONN
gathering
onicecandidate: 8b804542
onicecandidate: 8b804542
onicecandidate: 8b804542
onicecandidate: 8b804542
onicecandidate: 8b804542
complete
addIceCandidate: d7f75240
addIceCandidate: d7f75240
addIceCandidate: d7f75240

Actual results:

ONN
ONN
ONN
ONN
ONN
ONN
ONN
ONN
ONN
ONN
ONN
ONN
...

Workaround:

Uncomment the following code on line 58:

await pc.setLocalDescription(/* await pc.createOffer() */);

The bug is the zero-argument version of setLocalDescription fails to trigger ICE restart properly, doing a regular negotiation instead, after which ONN triggers again, ad infinitum.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

[Tracking Requested - why for this release]: Embarrassing behavioral flaw in restartIce() pattern which was designed for perfect negotiation. Would like this fixed for upcoming blog post.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1685833 - Test both zero and 1-argument SLD in RTCPeerConnection-restartIce.https.html

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1685833 - Make zero-argument version of setLocalDescription() respect restartIce() method.

Depends on D101254

Comment 4

[Julien Cristau [:jcristau]]

This bug has been around since 75 and not reported until now, doesn't seem warranted to track for 85.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da549b4201cc
Test both zero and 1-argument SLD in RTCPeerConnection-restartIce.https.html r=bwc
https://hg.mozilla.org/integration/autoland/rev/a9556ebc4a04
Make zero-argument version of setLocalDescription() respect restartIce() method. r=bwc

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/da549b4201cc
https://hg.mozilla.org/mozilla-central/rev/a9556ebc4a04

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27484 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot