Open Bug 1685863 Opened 5 years ago Updated 5 years ago

Lightning Item Modification Conflict pop-up let's you make the wrong decission

Categories

(Calendar :: Dialogs, enhancement)

x86_64
Linux
enhancement

Tracking

(Not tracked)

UNCONFIRMED

People

(Reporter: jaco, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

  • Open a task and change the body (don't save or close)
  • Open the same task again (opening another tab)
  • Change the body of the task in the second tab
  • Close the second tab
  • Confirm that you want to save the task
  • The following pop-up shows up:
    Item Modification Conflict
    The item being edited in the dialog has been modified since it was opened.
    [Discard these changes] [Overwrite the other changes]
  • I'm still seeing the second tab and as I just answered a question asked by this second tab it feels like the second tab is also asking this question. Let's say I forgot I was already editing in the first tab an realize I wrote a lot of text in the first tab yesterday and want to preserve it and discard me last edit in the second tab which was only a small edit which I can easily type again. I decide to not "Overwrite the other changes" but "Discard these changes" which I presume are the changes in the second tab.

Actual results:

The changes in the first tab are discarded and the changes in the second tab are saved.

Expected results:

The changes in the second tab should be discarded and the changes in the first tab should be preserved in the first tab to continue on and save it. That is at least what I expected but I now understand this pop-up comes from the first tab (although I still see the second tab). From a user perspective I don't think there's a way to know this when this pop-up pops up. And there's also no way to verify it or backup the data you entered in the task as this pop-up blocks any other action. You cannot switch to tab one so see what you did and copy the text. Thunderbird only allows you to click on one of the two buttons in the pop-up. It also doesn't give you a Cancel button (I now understand why because the second tab is already finished (but still visible) and this is a pop-up from the first tab (which isn't visible)).

I think it would be best to not make this message a pop-up blocking everything but a warning message in the Edit Task tab itself which give you the opportunity to backup data and/or resolve the conflict by opening the saved task again in a second tab and compare both tabs. This will also make it clear which tab is asking you the question / giving you a warning.

Another (easier) solution would be to totally remove this check/pop-up. It would then be up to the user to realize the task was openend twice and resolve this situation.

Or make it not possible to open the same task twice. When opening the second time just go to the first tab of give a warning the task is already open. For this solution it should be mentioned that the Item Modification Conflict pop-up can also pop-up when you snooze a task in the Reminders pop-up that is also open in a Edit tab. The Reminders pop-up will then modify the task that is open. It gives the same confusing situation (it feels like the Reminders pop-up is giving the Item Modification Conflict pop-up). Maybe there are other ways for tasks to be changed while it is open in an Edit tab so only preventing tasks to be open in one tab would not resolve all problems. Maybe in addition to only opening a task in one tab the task could also be "locked" so it cannot be changed by any other process while being open in a tab.

Thunderbird 68 is way past EOL, and I can not reproduce this using Thunderbird 78.6.0 with a local calendar.

I can reproduce this with my Google CalDAV network calendar.

Component: Untriaged → Dialogs
OS: Unspecified → Linux
Product: Thunderbird → Calendar
Hardware: Unspecified → x86_64
Version: 68 → unspecified

I'm on latest Ubuntu LTS (20.04) so I guess a lot of Linux users use this version. I see Thunderbird version 68.10.0 was released July 1, 2020. It is now already way past EOL?

Never looked at Ubuntu versions but looking at https://www.thunderbird.net/en-US/thunderbird/releases/ I suppose 78 is the current major release and 68 is the previous major release? Where can I find more information on how Thunderbird is using version numbers and when a version will be EOL?

(In reply to Jaco from comment #2)

I'm on latest Ubuntu LTS (20.04) so I guess a lot of Linux users use this version. I see Thunderbird version 68.10.0 was released July 1, 2020. It is now already way past EOL?

Never looked at Ubuntu versions but looking at https://www.thunderbird.net/en-US/thunderbird/releases/ I suppose 78 is the current major release and 68 is the previous major release? Where can I find more information on how Thunderbird is using version numbers and when a version will be EOL?

This might help with the how question.

https://www.thunderbird.net/en-US/organizations/

Thunderbird loosely follows the Firefox Release Calendar and version 78.x.x will be EOL when Thunderbird 91.3 is released.

Your issue is with a network calendar?

Which I would expect to produce an error because the user is changing the item on the server using Thunderbird. The changes are not saved to Thunderbird on the users computer.

Thanks for the information. I'll have a look.

I'm using an .ics file in my home folder (file:///home/jaco/.../Jaco.ics). I suppose it is more or less the same as a network calendar because you have to select On the Network in the Create a new calendar wizard to use an .ics file.

You need to log in before you can comment on or make changes to this bug.