1685880 - Compiling issues with GCC 7

Status: RESOLVED FIXED

(NSS :: Build, defect, P5)

Description

[arora.aashish]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36

Steps to reproduce:

Build issues with putenv function
Platform OEL 7
GCC version 7.3
run make nss_build_all USE_64=1 BUILD_OPT =1

Actual results:

cc -o Linux3.10_x86_64_cc_glibc_PTH_64_OPT.OBJ/secport.o -c -std=c99 -O2 -fPIC -m64 -pipe -ffunction-sections -fdata-sections -DHAVE_STRERROR -DLINUX -Dlinux -Wall -Wshadow -Werror -DXP_UNIX -UDEBUG -DNDEBUG -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_POSIX_SOURCE -DSQL_MEASURE_USE_TEMP_DIR -D_REENTRANT -DNSS_DISABLE_AVX2 -DNSS_NO_INIT_SUPPORT -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -I../../../dist/Linux3.10_x86_64_cc_glibc_PTH_64_OPT.OBJ/include -I../../../dist/public/nss -I../../../dist/private/nss secport.c
secport.c: In function ‘NSS_PutEnv_Util’:
secport.c:753:5: error: implicit declaration of function ‘putenv’ [-Werror=implicit-function-declaration]
putEnvFailed = putenv(encoded); /* adopt. */
^
cc1: all warnings being treated as errors

Expected results:

Should not get an error

Comment 1

[arora.aashish]

please refer to the fix https://github.com/nss-dev/nss/pull/24/files

Comment 2

[Benjamin Beurdouche [:beurdouche]]

Attachment: Bug 1685880 - Fix for the gcc compiler version 7 to support setenv with nss build. r=rrelyea

Comment 3

[arora.aashish]

@benjamin, Thank you for prioritizing this. Do you need anything from me to proceed further

Comment 4

[arora.aashish]

Hi Benjamin, I see the feedback from "rrelyea". I have done the suggested changes could you please take the latest from https://github.com/nss-dev/nss/pull/24/files and push them to Mozilla repositories

Comment 5

[Benjamin Beurdouche [:beurdouche]]

Attachment: Bug 1685880 - Minor fix to prevent unused variable on early return. r=beurdouche

Depends on D104418

Comment 6

[Benjamin Beurdouche [:beurdouche]]

https://hg.mozilla.org/projects/nss/rev/c1974e72e099ff45f3e0e3d1ab0a1b2e969dfc4a
https://hg.mozilla.org/projects/nss/rev/80793a75363d262804531f064a1936bf0fbd3d82