Closed
Bug 1685940
Opened 3 years ago
Closed 3 years ago
Subscribe dialog should use the new offline strings in SeaMonkey 2.53.x and 2.57
Categories
(SeaMonkey :: MailNews: Account Configuration, defect)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
RESOLVED
FIXED
seamonkey2.53
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.6)
Attachments
(1 file)
|
1.27 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Even though we included the extra strings in Bug 1673959, they were not hooked into the code.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: old strings used
Testing completed (on m-c, etc.): 2.53.6
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Attachment #9196291 -
Flags: review?(frgrahl)
Attachment #9196291 -
Flags: approval-comm-release?
Attachment #9196291 -
Flags: approval-comm-esr60?
|
||
Comment 2•3 years ago
|
||
Comment on attachment 9196291 [details] [diff] [review]
1685940-subscribe-offline-2536.patch
LGTM
Attachment #9196291 -
Flags: review?(frgrahl)
Attachment #9196291 -
Flags: review+
Attachment #9196291 -
Flags: approval-comm-release?
Attachment #9196291 -
Flags: approval-comm-release+
Attachment #9196291 -
Flags: approval-comm-esr60?
Attachment #9196291 -
Flags: approval-comm-esr60+
|
|
||
Comment 3•3 years ago
|
||
2.53 and 2.57 branches only.
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → affected
tracking-seamonkey2.53:
--- → ?
tracking-seamonkey2.57esr:
--- → ?
Summary: Subscribe dialog should use the new offline strings → Subscribe dialog should use the new offline strings in SeaMonkey 2.53.x and 2.57
Version: Trunk → SeaMonkey 2.53 Branch
|
|
||
Comment 4•3 years ago
•
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/e22e000ff85144fd23d6dab925a80497aad16a8f
Subscribe dialog should use the new offline strings. r=frg a=frg
Whiteboard: SM2.53.6
Target Milestone: --- → seamonkey2.53
|
|
||
Updated•3 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•