class selectors on non-subject sequence of simple selectors always match XML content

VERIFIED FIXED in mozilla1.2beta

Status

()

defect
P2
major
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({testcase})

Trunk
mozilla1.2beta
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(2 attachments)

Sicking noticed that class selectors on (using CSS3 terminology) in any
non-subject sequence of simple selectors always match XML content.  This is bad,
and seems to be due to the NS_COMFALSE nightmare of nsIStyledContent::HasClass
and the inconsistency with GetClasses.
Posted file sicking's testcase
There should not be any red in this testcase.
This is the simple fix.  We might want to clean things up a bit, though, to
avoid the hated NS_COMFALSE.
Yeah.  I say it's time for NS_IMETHOD_(PRBool) here.  sr=me on the patch if
that's needed immediately, though.
Comment on attachment 99163 [details] [diff] [review]
the simple fix without any cleanup

r=sicking
Attachment #99163 - Flags: review+
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.2beta
Fix checked in, 2002-09-16 07:17 PDT.

Filed bug 169088 on fixing the API to avoid NS_COMFALSE (yes, I'm lame).
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
verified 
Status: RESOLVED → VERIFIED
Keywords: testcase
You need to log in before you can comment on or make changes to this bug.