Closed Bug 1685991 Opened 5 months ago Closed 5 months ago

Add a Nightly Experiment option to search during IME composition

Categories

(Firefox :: Address Bar, task, P2)

task
Points:
3

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: mak, Assigned: amy)

References

Details

Attachments

(2 files)

See bug 1673971, for now we can't easily detect whether we should search during IME or not, but we know that some users prefer that, and that when IME doesn't open a picker, the experience may be better.
To spread awareness of this pref, for now we can add a Nightly Experiment checkbox for it.

Points: --- → 1
Assignee: nobody → achurchwell

Hi Mak! Finally able to get to this.
In Features.toml I am not sure what the preference value should be for this new option. I saw https://hg.mozilla.org/integration/autoland/rev/7792ae96b5bb and am thinking it should be something imeCompositionClosesPanel?

Flags: needinfo?(mak)

It's browser.urlbar.imeCompositionClosesPanel. It's added here in firefox.js. That file lists most of the prefs available in Firefox.

Flags: needinfo?(mak)
Attachment #9198026 - Attachment description: Bug 1685991- Add a Nightly Experiment option to search during IME composition. r?harry → Bug 1685991 - Change default value of IME composition pref and add it to Nightly Experiments. r?harry

The scope of this bug now entails a bunch of changes to a pref, its tests, and a pref migration, so I'm bumping the points.

Points: 1 → 3
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0bc10e33507
Change default value of IME composition pref and add it to Nightly Experiments. r=harry,fluent-reviewers,preferences-reviewers,Gijs,flod
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch

The comment talking about the default value being "true" is now wrong. https://hg.mozilla.org/mozilla-central/rev/c0bc10e33507#l1.14

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/84c563c1aa29
add "browser.urlbar.keepPanelOpenDuringImeComposition" pref to Thunderbird, to avoid test failures. rs=bustage-fix
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79424a908a26
Follow up - Update comment with correct value. r=harry
You need to log in before you can comment on or make changes to this bug.