1686013 - macOS [Synced Tabs Sidebar] focus for device section not visible when browser in use

Status: NEW

(Firefox :: Theme, defect)

Description

[Cristian Fogel [:cfogel]]

Attachment: Screenshot 2021-01-11 at 13.37.11.png

Affected versions

• 85.0b7, 86.0a1(2020-01-10);

Affected platforms

• macOS 11.0, macOS 10.13, macOS 10.15;

Steps to reproduce

1. Launch Firefox, sign in with a sync'd account to another device;
2. Enable the browser sidebar;
3. Choose to show the Synced Tabs (if none are displayed, can login on another device so this enables);
4. Click the username Firefox on pcName to expand list of sync'd tabs;
5. Click on any link from the expanded list;
6. Click on the top leaf again so no tab is selected;

Expected result

• selection is visible on the clicked top-leaf;

Actual result

• no focus indicator on the selection;

Regression range

• checked on macOS 10.15;
• last good: 2020-06-18;
• first bad: 2020-06-19;
• pushlog URL;
• potential regressor: bug 1646842;

Additional notes

• same for light-dark theme both browser/OS;
• attached screenshot with the issue on light theme since it's having the worst impact, on dark theme it's not visible; light theme both browser and OS
• issue clears/resets if swapping to another application;
• after updating regressor, checked with WebRender off/on but the same issue manifests on both states.

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Jeff, it seems that this is a webrender bug, is that on your team radar? Thanks

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I'm unable to reproduce this locally on my 2019 MBP. Christian, can you confirm that you see the issue with WebRender on and with it off?

Comment 3

[Cristian Fogel [:cfogel]]

87.0a1(2020-02-11) still manifests this behavior.

For the initial report it was in the default (disabled) state.
However, it has the same behavior with WebRender enabled.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Can you attach the graphics section of about:support?

Comment 5

[Cristian Fogel [:cfogel]]

Attachment: cgraphs.rtf

Comment 6

[Jeff Muizelaar [:jrmuizel]]

WebRender should've been enabled originally, do you know why it was disabled? Can you get a new regression window with gfx.webrender.all=true set?

Comment 7

[Cristian Fogel [:cfogel]]

Looking a second time, the pref was set on false as default (even off fresh profiles - on nightly).
Checking with morzregression again with the pref set on true, noticed that the originial issue can be split into 3 breakpoints:

1. the issue manifests on dark theme(this if I recall right is treated in another bug report);
2. the issue manifests on light theme while the page loads only;
3. the issue manifests and persists- light theme (this being the one for the initial report).

Regression range for (2) - with gfx.webrender.all=true

• last good: 2019-10-03;
• first bad: 2019-10-04;
• Pushlog URL;