1686137 - install_mobile_android_sdk_or_ndk relies on wget

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, task, P3)

Description

[Mike Hommey [:glandium]]

We should avoid relying on wget, which is not available on macOS by default. We currently do install it via homebrew or macports, but it would be better if we didn't need that.

Assuming we run the code after the virtualenv is created, we should have the requests module available anyways, so there isn't really a reason to use an external program to download stuff.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

This is a little bit non-trivial, since we probably want to keep wget's --continue behaviour.
As part of re-implementing this with requests, we should intelligently continue interrupted downloads.

Comment 3

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1686137 - Replace wget with requests in install_mobile_android_sdk_or_ndk to reduce external dependency r=mhentges

By using requests we remove an external dependency (wget) that may not always be
available. The '--continue' functionality from wget is implemented via pathlib.

Comment 4

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1686137 - Replace 'wget' with 'requests' in install_mobile_android_sdk_or_ndk to remove the external dependency on 'wget' r=mhentges g=firefox-build-system-reviewers

By using requests we remove an external dependency (wget) that may not always be
available. The '--continue' functionality from wget is implemented via pathlib.

Comment 5

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1686137 - Vendor 'tqdm' progress bar library r?mhentges

Source here: https://github.com/tqdm/tqdm

Comment 6

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1686137 - [WILL-SQUASH] Vendored `tqdm` r?mhentges

Source here: https://github.com/tqdm/tqdm

Comment 7

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1686137 - Vendor 'colorama' library r?mhentges, g?firefox-build-system-reviewers

Colorama enables colored text on terminal windows.

'tqdm' depends on Colorama on Windows.

Project Link: https://pypi.org/project/colorama/

Comment 8

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1686137 - Vendor 'colorama' library -WILL SQUASH- r?mhentges, g?firefox-build-system-reviewers

Depends on D130121

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/493626d35826
Vendor 'tqdm' progress bar library r=mhentges
https://hg.mozilla.org/integration/autoland/rev/bfe4d253ce87
Vendor 'colorama' library r=mhentges, g?firefox-build-system-reviewers
https://hg.mozilla.org/integration/autoland/rev/3bf13dec098d
Replace 'wget' with 'requests' in install_mobile_android_sdk_or_ndk to remove the external dependency on 'wget' r=mhentges,firefox-build-system-reviewers g=firefox-build-system-reviewers

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/493626d35826
https://hg.mozilla.org/mozilla-central/rev/bfe4d253ce87
https://hg.mozilla.org/mozilla-central/rev/3bf13dec098d