1686140 - Incremental build fails: cannot find function `register_pings` in module `fog::pings`

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

 1:34.54    Compiling fog_control v0.1.0 (C:\Users\Kagami\Documents\GitHub\gecko-dev\toolkit\components\glean)
 1:35.44 error[E0425]: cannot find function `register_pings` in module `fog::pings`
 1:35.44    --> toolkit\components\glean\src\lib.rs:127:21
 1:35.44     |
 1:35.44 127 |         fog::pings::register_pings();
 1:35.44     |                     ^^^^^^^^^^^^^^ not found in `fog::pings`

Comment 1

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Deleting (objdir)/toolkit/components/glean/api/src triggers proper rebuild.

Comment 2

[Jan-Erik Rediger [:janerik]]

I guess we should somehow tell the build system that changing the templates requires rebuilding the files.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1681731

Comment 4

[Chris H-C :chutten]

(In reply to Jan-Erik Rediger [:janerik] from comment #2)

I guess we should somehow tell the build system that changing the templates requires rebuilding the files.

Yup. I've been meaning to add the templates and scripts to the GeneratedFile directives. Guess I should've done them before now, sorry about that krosylight.

Comment 5

[Chris H-C :chutten]

Attachment: Bug 1686140 - Changes to dependent scripts should regenerate metrics and pings files in FOG r?janerik!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15ee145790bb
Changes to dependent scripts should regenerate metrics and pings files in FOG r=janerik

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/15ee145790bb