1686187 - Use AMO api v4 in Firefox

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Andrew Williamson [:eviljeff]]

Firefox currently uses the AMO API https://addons-server.readthedocs.io/en/latest/topics/api/v3_legacy/index.html in a few different places. AMO is beginning the process[1] of deprecating that API so Firefox needs to move to a more recent version, v4, so functionality isn't impacted.

Although there have been many changes since the v4 split [2], it's quite likely Firefox doesn't actually use any of the affected endpoints. (If there is use, then [3] are the current server-side patches enabled for v3 that translate the default v5 functionality, which should be a guide to what changes would be needed)

[1] https://github.com/mozilla/addons-server/issues/11273
[2] https://addons-server.readthedocs.io/en/latest/topics/api/overview.html#v4-api-changelog
[3] https://github.com/mozilla/addons-server/blob/master/src/olympia/lib/settings_base.py#L1585:L1601

p.s. Product/Component may be incorrect; move as appropriate.

Comment 1

[William Durand [:willdurand] (back on May 25th)]

Attachment: Bug 1686187 - Use AMO API v4. r=robwu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea4ec9623efe
Use AMO API v4. r=robwu

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ea4ec9623efe

Comment 4

[Shane Caraveo (:mixedpuppy)]

[Tracking Requested - why for this release]: While this will ride the train to release, we'd like to track for ESR 78.9 uplift.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

To make sure we're on the same page, this is riding to release alongside Fx86, but you want it to ship in ESR 78.9 alongside Fx87?

Comment 6

[Shane Caraveo (:mixedpuppy)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

To make sure we're on the same page, this is riding to release alongside Fx86, but you want it to ship in ESR 78.9 alongside Fx87?

sigh. same esr as fx86, so 78.8

Comment 7

[William Durand [:willdurand] (back on May 25th)]

Comment on attachment 9197378 [details]
Bug 1686187 - Use AMO API v4. r=robwu

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Without this patch, ESR 78 would continue to use the AMO API v3, which is being deprecated. Adopting AMO API v4 in ESR would significantly reduce the usage of the AMO API v3.
• User impact if declined: Since API v4 is now the stable version, we think that this patch should generally be beneficial to end users as it would lower the (fairly low) risk of regressions in the now deprecated API v3.
• Fix Landed on Version: 86
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only changes and API version in a few prefs (and remove code we're not using for a long time). API versions v3 and v4 aren't that different either and we did not notice any regression in Nightly.
• String or UUID changes made by this patch:

Comment 8

[William Durand [:willdurand] (back on May 25th)]

The patch above applies cleanly on the esr-78 branch and I pushed to Try to be sure.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9197378 [details]
Bug 1686187 - Use AMO API v4. r=robwu

Approved for 78.8esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/cf0507a516ff