Investigate not selecting a node when clicking on its expand/collapse arrow
Categories
(DevTools :: Inspector, task, P3)
Tracking
(firefox87 fixed)
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: jdescottes)
Details
Attachments
(2 files)
At the moment, when expanding a node, we also select the node, which triggers a few updates on the panel (depending which sidepanel is open).
On heavy pages, this can cause jank and make navigation frustrating (See Bug 1686240).
We could try to not select the node if the user only clicks on the expand arrow.
For what it's worth, it looks like what Chrome and Safari is doing.
|
Assignee | |
Comment 1•3 years ago
|
||
Sounds interesting, let's see how many failures we get: https://treeherder.mozilla.org/jobs?repo=try&revision=28a18b2ac159682dec256741a689879ae3b4ffd3
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
Let's move this forward, testing on youtube, it makes the experience nicer when using the mouse to expand containers.
Allows to explore the tree without having to wait for seconds everytime a container gets selected.
|
|
Assignee | |
Comment 3•3 years ago
|
||
The existing helper expandContainerByClick is modified to support the "altKey" option and reused in all tests that try to click on markup-view container expand-icons.
A similar collapseContainerByClick is also added for symmetry. Both methods will become identical once we stop selecting the node on expand and they will be merged.
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D103051.
Other browser devtools do not select the node on expand. Selecting the node can be quite slow when if many CSS rules apply to it.
This should allow exploring the tree of complex pages with less slowdowns.
An existing test is updated to assert the selected state of the node container before/after expanding it.
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2089c69e453b [devtools] Use shared test helpers to toggle markup-view containers r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/5facb25bb1e5 [devtools] Stop selecting the node front when expanding the markup view container r=nchevobbe
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2089c69e453b
https://hg.mozilla.org/mozilla-central/rev/5facb25bb1e5
Description
•