Open Bug 1686294 Opened 5 years ago Updated 4 years ago

videocontrols.js restricts some video control behaviour based on documentURI which is bogus

Categories

(Toolkit :: UI Widgets, defect, P3)

Desktop
All
defect

Tracking

()

Tracking Status
firefox86 --- affected

People

(Reporter: Gijs, Unassigned)

References

Details

STR:

  1. open https://www.w3.org/2010/05/video/mediaevents.html
  2. check document.documentURI (starts with https)
  3. call window.open("about:blank", "_blank", "height=500") from the same place, and check document.documentURI for that (won't start with https, I think - if not, same thing but for file URIs or data: uris or whatever)

ER:

absence/presence of controls / bindings shouldn't depend on documentURI

AR:
they do. Not sure why.

This is from https://phabricator.services.mozilla.com/D26804 but I don't see a discussion there or in bug 1543128 about this restriction. Mike, do you recall why this is?

Flags: needinfo?(mconley)

Looks like an original landing that got backed out didn't have the check https://hg.mozilla.org/integration/autoland/rev/a2e73d143aba and then the reland at https://hg.mozilla.org/integration/autoland/rev/3ac660e7f45c did.

(In reply to Brian Grinstead [:bgrins] from comment #2)

Looks like an original landing that got backed out didn't have the check https://hg.mozilla.org/integration/autoland/rev/a2e73d143aba and then the reland at https://hg.mozilla.org/integration/autoland/rev/3ac660e7f45c did.

Looks like maybe related bug 1544257? But I can't tell if this was an attempt to fix it that ended up being necessary or not.

Mike, do you recall why the check Brian mentioned in comment 2 changed?

Wooo 1yr old needinfo. Sorry, gang.

I'm afraid I don't recall. :( I also can't think of a good reason why this would be necessary.

Flags: needinfo?(mconley)
Severity: -- → S3
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.